Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4860)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java

Issue 1947493002: Site Settings Android: A few polish items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java
new file mode 100644
index 0000000000000000000000000000000000000000..9176f4d6f5bbf929fb53a0b8e43ef820d2c0f294
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java
@@ -0,0 +1,34 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.preferences.website;
+
+import android.content.Context;
+import android.preference.Preference;
+import android.util.AttributeSet;
+import android.util.TypedValue;
+import android.view.View;
+import android.widget.ImageView;
+
+/**
+ * A custom preference for drawing Site Settings entries.
+ */
+public class SiteSettingsPreference extends Preference {
+ /**
+ * Constructor for inflating from XML.
+ */
+ public SiteSettingsPreference(Context context, AttributeSet attrs) {
+ super(context, attrs);
+ }
+
+ @Override
+ protected void onBindView(View view) {
+ super.onBindView(view);
+
+ int margin = (int) TypedValue.applyDimension(
+ TypedValue.COMPLEX_UNIT_DIP, 4.6f, getContext().getResources().getDisplayMetrics());
+ ImageView icon = (ImageView) view.findViewById(android.R.id.icon);
+ icon.setPadding(margin, icon.getPaddingTop(), 0, icon.getPaddingBottom());
Theresa 2016/05/04 16:33:10 Can we use a defined dimen for the margin instead
Finnur 2016/05/06 15:12:44 Not sure what you mean... The setPadding param is
Theresa 2016/05/06 15:58:16 Typically we use Resources.getDimensionPixelSize()
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698