Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1947473002: Revert of [heap] Fix clearing slots for map and size during LeftTrimFixedArray (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Jakob Kummerow, Camillo Bruni
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Fix clearing slots for map and size during LeftTrimFixedArray (patchset #1 id:1 of https://codereview.chromium.org/1943263002/ ) Reason for revert: GC-stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305/steps/Mjsunit/logs/array-copywithin Original issue's description: > [heap] Fix clearing slots for map and size during LeftTrimFixedArray > > BUG=chromium:598319 > LOG=N > > Committed: https://crrev.com/5aa1d9c3cfde4389fb5a34e98a5dccbca9dc9f12 > Cr-Commit-Position: refs/heads/master@{#35970} TBR=ulan@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:598319 Committed: https://crrev.com/a4129bb45a3bb8cc68bb2e07ee1e0a734f04ce4b Cr-Commit-Position: refs/heads/master@{#35979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/heap/heap.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
Created Revert of [heap] Fix clearing slots for map and size during LeftTrimFixedArray
4 years, 7 months ago (2016-05-03 13:04:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947473002/1
4 years, 7 months ago (2016-05-03 13:05:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 13:05:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a4129bb45a3bb8cc68bb2e07ee1e0a734f04ce4b Cr-Commit-Position: refs/heads/master@{#35979}
4 years, 7 months ago (2016-05-03 13:05:54 UTC) #5
Michael Lippautz
4 years, 7 months ago (2016-05-03 14:13:11 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1947503002/ by mlippautz@chromium.org.

The reason for reverting is: Unrelated to waterfall failures..

Powered by Google App Engine
This is Rietveld 408576698