Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1947413004: [tools] Add callstats.html to analize --runtime-call-stats output (Closed)

Created:
4 years, 7 months ago by Camillo Bruni
Modified:
4 years, 7 months ago
Reviewers:
nickie
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Add callstats.html to analize --runtime-call-stats output callstats.html in combination with callstats.py can be used to get an in-depth view on where we spend time in v8. Furthermore, with callstats.html we can compare different versions of v8/chrome and see where and how performnce evolved. Drive-by-fix: add missing copyrights header to ic-explorer.html and format ic-explorer.html BUG= Committed: https://crrev.com/aa1b7f6b816d95aa381dcdab0ee15ddf956b5a8f Cr-Commit-Position: refs/heads/master@{#36080}

Patch Set 1 #

Total comments: 13

Patch Set 2 : fixing bugs #

Patch Set 3 : addressing nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1626 lines, -298 lines) Patch
A tools/callstats.html View 1 2 1 chunk +1316 lines, -0 lines 0 comments Download
M tools/ic-explorer.html View 1 2 1 chunk +310 lines, -298 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Camillo Bruni
PTAL
4 years, 7 months ago (2016-05-06 11:19:16 UTC) #3
nickie
LGTM, other than my non-intelligent comments (mostly about formatting). Also, the formatter complains about trailing ...
4 years, 7 months ago (2016-05-06 12:40:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947413004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947413004/40001
4 years, 7 months ago (2016-05-06 12:49:55 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-06 13:23:56 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 13:24:46 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aa1b7f6b816d95aa381dcdab0ee15ddf956b5a8f
Cr-Commit-Position: refs/heads/master@{#36080}

Powered by Google App Engine
This is Rietveld 408576698