Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1947413003: X87: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm me… (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory size references in generated code. port 117a56b7c2a88ab2b2f25fad88517d72f5edbac9 (r36044) original commit message: - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add relocation information to immediates in compare instructions. - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler BUG= Committed: https://crrev.com/23a650ed07d184176683d973483815fd919c2c07 Cr-Commit-Position: refs/heads/master@{#36058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -24 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M src/x87/assembler-x87-inl.h View 2 chunks +0 lines, -20 lines 0 comments Download
M test/cctest/test-run-wasm-relocation-x87.cc View 3 chunks +64 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-06 02:16:23 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-06 02:50:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947413003/1
4 years, 7 months ago (2016-05-06 04:52:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 07:28:38 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 07:31:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23a650ed07d184176683d973483815fd919c2c07
Cr-Commit-Position: refs/heads/master@{#36058}

Powered by Google App Engine
This is Rietveld 408576698