[interpreter] Introduce bytecode generation pipeline.

test/unittests/interpreter/bytecode-array-writer-unittest.cc

Index: test/unittests/interpreter/bytecode-array-writer-unittest.cc
diff --git a/test/unittests/interpreter/bytecode-array-writer-unittest.cc b/test/unittests/interpreter/bytecode-array-writer-unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..38a21b5145efb7c2d782b5b9c739ed0921c64d8d
--- /dev/null
+++ b/test/unittests/interpreter/bytecode-array-writer-unittest.cc
@@ -0,0 +1,198 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/v8.h"
+
+#include "src/interpreter/bytecode-array-writer.h"
+#include "src/interpreter/source-position-table.h"
+#include "src/isolate.h"
+#include "src/utils.h"
+#include "test/unittests/interpreter/bytecode-utils.h"
+#include "test/unittests/test-utils.h"
+
+namespace v8 {
+namespace internal {
+namespace interpreter {
+
+class BytecodeArrayWriterUnittest : public TestWithIsolateAndZone {
+ public:
+  BytecodeArrayWriterUnittest()
+      : source_position_builder_(isolate(), zone()),
+        bytecode_array_writer_(zone(), &source_position_builder_) {}
+  ~BytecodeArrayWriterUnittest() override {}
+
+  SourcePositionTableBuilder* source_position_builder() {
+    return &source_position_builder_;
+  }
+  BytecodeArrayWriter* writer() { return &bytecode_array_writer_; }
+
+ private:
+  SourcePositionTableBuilder source_position_builder_;
+  BytecodeArrayWriter bytecode_array_writer_;
+};
+
+TEST_F(BytecodeArrayWriterUnittest, SimpleExample) {
+  CHECK_EQ(writer()->bytecodes()->size(), 0);
+
+  BytecodeNode node0(Bytecode::kStackCheck);
+  node0.source_info().Update({10, false});
+  writer()->Write(&node0);
+  CHECK_EQ(writer()->bytecodes()->size(), 1);
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 0);
+
+  BytecodeNode node1(Bytecode::kLdaSmi, 0xff, OperandScale::kSingle);
+  node1.source_info().Update({55, true});
+  writer()->Write(&node1);
+  CHECK_EQ(writer()->bytecodes()->size(), 3);
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 0);
+
+  BytecodeNode node2(Bytecode::kLdar, Register(1).ToOperand(),
+                     OperandScale::kDouble);
+  writer()->Write(&node2);
+  CHECK_EQ(writer()->bytecodes()->size(), 7);
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 2 * kPointerSize);
+
+  BytecodeNode node3(Bytecode::kReturn);
+  node3.source_info().Update({70, true});
+  writer()->Write(&node3);
+  CHECK_EQ(writer()->bytecodes()->size(), 8);
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 2 * kPointerSize);
+
+  static const uint8_t bytes[] = {B(StackCheck), B(LdaSmi), U8(0xff), B(Wide),
+                                  B(Ldar),       R16(1),    B(Return)};
+  CHECK_EQ(writer()->bytecodes()->size(), arraysize(bytes));
+  for (size_t i = 0; i < arraysize(bytes); ++i) {
+    CHECK_EQ(writer()->bytecodes()->at(i), bytes[i]);
+  }
+
+  CHECK_EQ(writer()->FlushForOffset(), arraysize(bytes));
+  writer()->FlushBasicBlock();
+  CHECK_EQ(writer()->bytecodes()->size(), arraysize(bytes));
+
+  PositionTableEntry expected_positions[] = {
+      {0, 10, false}, {1, 55, true}, {7, 70, true}};
+  Handle<ByteArray> source_positions =
+      source_position_builder()->ToSourcePositionTable();
+  SourcePositionTableIterator source_iterator(*source_positions);
+  for (size_t i = 0; i < arraysize(expected_positions); ++i) {
+    const PositionTableEntry& expected = expected_positions[i];
+    CHECK_EQ(source_iterator.bytecode_offset(), expected.bytecode_offset);
+    CHECK_EQ(source_iterator.source_position(), expected.source_position);
+    CHECK_EQ(source_iterator.is_statement(), expected.is_statement);
+    source_iterator.Advance();
+  }
+  CHECK(source_iterator.done());
+}
+
+
+TEST_F(BytecodeArrayWriterUnittest, ComplexExample) {
+  static const uint8_t expected_bytes[] = {
+// clang-format off

[rmcilroy, 2016/05/12 12:15:14]

nit - indent

[oth, 2016/05/12 14:59:53]

Done.

+      /*  0 30 E> */ B(StackCheck),
+      /*  1 42 S> */ B(LdaConstant), U8(0),
+      /*  3 42 E> */ B(Star), R8(1),
+      /*  5 68 S> */ B(JumpIfUndefined), U8(38),
+      /*  7       */ B(JumpIfNull), U8(36),
+      /*  9       */ B(ToObject),
+      /* 10       */ B(Star), R8(3),
+      /* 12       */ B(ForInPrepare), R8(4),
+      /* 14       */ B(LdaZero),
+      /* 15       */ B(Star), R8(7),
+      /* 17 63 S> */ B(ForInDone), R8(7), R8(6),
+      /* 20       */ B(JumpIfTrue), U8(23),
+      /* 22       */ B(ForInNext), R8(3), R8(7), R8(4), U8(1),
+      /* 27       */ B(JumpIfUndefined), U8(10),
+      /* 29       */ B(Star), R8(0),
+      /* 31 54 E> */ B(StackCheck),
+      /* 32       */ B(Ldar), R8(0),
+      /* 34       */ B(Star), R8(2),
+      /* 36 85 S> */ B(Return),
+      /* 37       */ B(ForInStep), R8(7),
+      /* 39       */ B(Star), R8(7),
+      /* 41       */ B(Jump), U8(-24),
+      /* 43       */ B(LdaUndefined),
+      /* 44 85 S> */ B(Return),
+// clang-format on

[rmcilroy, 2016/05/12 12:15:14]

nit - indent

[oth, 2016/05/12 14:59:53]

Done.

+  };
+
+  static const PositionTableEntry expected_positions[] = {
+      {0, 30, false}, {1, 42, true},   {3, 42, false}, {5, 68, true},
+      {17, 63, true}, {31, 54, false}, {36, 85, true}, {44, 85, true}};
+
+#define NODE(node_args)          \

[rmcilroy, 2016/05/12 12:15:14]

Nit - these could be helper functions instead of macros (I think that would be
clearer).

[oth, 2016/05/12 14:59:53]

Done.

+  {                              \
+    BytecodeNode node node_args; \
+    writer()->Write(&node);      \
+  }
+
+#define NODE_SP(node_args, source_position, statement)       \
+  {                                                          \
+    BytecodeNode node node_args;                             \
+    node.source_info().Update({source_position, statement}); \
+    writer()->Write(&node);                                  \
+  }
+
+#define R(i) static_cast<uint32_t>(Register(i).ToOperand())
+
+  NODE_SP((Bytecode::kStackCheck), 30, false);
+  NODE_SP((Bytecode::kLdaConstant, U8(0), OperandScale::kSingle), 42, true);
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 0 * kPointerSize);
+  NODE_SP((Bytecode::kStar, R(1), OperandScale::kSingle), 42, false);
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 2 * kPointerSize);
+  NODE_SP((Bytecode::kJumpIfUndefined, U8(38), OperandScale::kSingle), 68,
+          true);
+  NODE((Bytecode::kJumpIfNull, U8(36), OperandScale::kSingle));
+  NODE((Bytecode::kToObject));
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 2 * kPointerSize);
+  NODE((Bytecode::kStar, R(3), OperandScale::kSingle));
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 4 * kPointerSize);
+  NODE((Bytecode::kForInPrepare, R(4), OperandScale::kSingle));
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 7 * kPointerSize);
+  NODE((Bytecode::kLdaZero));
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 7 * kPointerSize);
+  NODE((Bytecode::kStar, R(7), OperandScale::kSingle));
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 8 * kPointerSize);
+  NODE_SP((Bytecode::kForInDone, R(7), R(6), OperandScale::kSingle), 63, true);
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 8 * kPointerSize);
+  NODE((Bytecode::kJumpIfTrue, U8(23), OperandScale::kSingle));
+  NODE((Bytecode::kForInNext, R(3), R(7), R(4), U8(1), OperandScale::kSingle));
+  NODE((Bytecode::kJumpIfUndefined, U8(10), OperandScale::kSingle));
+  NODE((Bytecode::kStar, R(0), OperandScale::kSingle));
+  NODE_SP((Bytecode::kStackCheck), 54, false);
+  NODE((Bytecode::kLdar, R(0), OperandScale::kSingle));
+  NODE((Bytecode::kStar, R(2), OperandScale::kSingle));
+  NODE_SP((Bytecode::kReturn), 85, true);
+  NODE((Bytecode::kForInStep, R(7), OperandScale::kSingle));
+  NODE((Bytecode::kStar, R(7), OperandScale::kSingle));
+  NODE((Bytecode::kJump, U8(-24), OperandScale::kSingle));
+  NODE((Bytecode::kLdaUndefined));
+  NODE_SP((Bytecode::kReturn), 85, true);
+  CHECK_EQ(writer()->GetMeasuredFrameSize(), 8 * kPointerSize);
+
+#undef NODE
+#undef NODE_SP
+#undef R
+
+  CHECK_EQ(writer()->bytecodes()->size(), arraysize(expected_bytes));
+  for (size_t i = 0; i < arraysize(expected_bytes); ++i) {
+    CHECK_EQ(static_cast<int>(writer()->bytecodes()->at(i)),
+             static_cast<int>(expected_bytes[i]));
+  }
+
+  Handle<ByteArray> source_positions =
+      source_position_builder()->ToSourcePositionTable();
+  SourcePositionTableIterator source_iterator(*source_positions);
+  for (size_t i = 0; i < arraysize(expected_positions); ++i) {
+    const PositionTableEntry& expected = expected_positions[i];
+    CHECK_EQ(source_iterator.bytecode_offset(), expected.bytecode_offset);
+    CHECK_EQ(source_iterator.source_position(), expected.source_position);
+    CHECK_EQ(source_iterator.is_statement(), expected.is_statement);
+    source_iterator.Advance();
+  }
+  CHECK(source_iterator.done());
+}
+
+}  // namespace interpreter
+}  // namespace internal
+}  // namespace v8