test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden - Issue 1947403002: [interpreter] Introduce bytecode generation pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden

Issue 1947403002: [interpreter] Introduce bytecode generation pipeline. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Incorporate comments on patch set 6. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/source-position-table.h ('K') | « test/cctest/interpreter/bytecode_expectations/Generators.golden ('k') | test/unittests/interpreter/bytecode-array-builder-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden b/test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden

index 77d1bd18db4d236d7efa962ef73ccf8506fce439..fed8367212b4e9a1dc3402167e164c163a761f14 100644

--- a/test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden

+++ b/test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden

@@ -119,7 +119,7 @@ snippet: "

frame size: 3

parameter count: 1

-bytecode array length: 32

+bytecode array length: 24

bytecodes: [

/* 30 E> */ B(StackCheck),

/* 42 S> */ B(LdaSmi), U8(2),

@@ -129,12 +129,8 @@ bytecodes: [

/* 56 S> */ B(LdaSmi), U8(4),

/* 56 E> */ B(Star), R(2),

/* 59 S> */ B(Ldar), R(0),

- B(JumpIfToBooleanTrue), U8(16),

- /* 72 E> */ B(Ldar), R(0),

- /* 75 E> */ B(Ldar), R(1),

- /* 78 E> */ B(Ldar), R(0),

- /* 81 E> */ B(Ldar), R(1),

- B(LdaSmi), U8(5),

+ B(JumpIfToBooleanTrue), U8(8),

+ /* 81 E> */ B(LdaSmi), U8(5),

/* 86 E> */ B(Star), R(2),

B(LdaSmi), U8(3),

/* 95 S> */ B(Return),