src/compiler/bytecode-graph-builder.cc - Issue 1947403002: [interpreter] Introduce bytecode generation pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 1947403002: [interpreter] Introduce bytecode generation pipeline. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Incorporate comments on patch set 6. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/bytecode-graph-builder.cc

diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc

index 8fb7b69f403ea6cfe7e8a02af70a7a983044675a..513d3e0703891293d676376dff812a37a835a003 100644

--- a/src/compiler/bytecode-graph-builder.cc

+++ b/src/compiler/bytecode-graph-builder.cc

@@ -1423,6 +1423,8 @@ void BytecodeGraphBuilder::VisitIllegal() {

jsgraph()->Constant(kIllegalBytecode));

}

+void BytecodeGraphBuilder::VisitNop() {}

void BytecodeGraphBuilder::SwitchToMergeEnvironment(int current_offset) {

if (merge_environments_[current_offset] != nullptr) {

if (environment() != nullptr) {