test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden - Issue 1947403002: [interpreter] Introduce bytecode generation pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden

Issue 1947403002: [interpreter] Introduce bytecode generation pipeline. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Incorporate review comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/source-position-table.cc ('K') | « test/cctest/interpreter/bytecode_expectations/LetVariable.golden ('k') | test/cctest/interpreter/bytecode_expectations/PrimitiveExpressions.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden b/test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden

index cddb9a14291f434dea9d69ddcac7761e89601ccf..e70604f939d66b4437d39398a1387765bce5e9d5 100644

--- a/test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden

+++ b/test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden

@@ -13,11 +13,12 @@ snippet: "

frame size: 1

parameter count: 1

-bytecode array length: 9

+bytecode array length: 10

bytecodes: [

B(StackCheck),

B(LdaZero),

B(Star), R(0),

+ B(Nop),

B(JumpIfToBooleanTrue), U8(4),

B(LdaSmi), U8(3),

B(Return),

@@ -56,11 +57,12 @@ snippet: "

frame size: 1

parameter count: 1

-bytecode array length: 9

+bytecode array length: 10

bytecodes: [

B(StackCheck),

B(LdaZero),

B(Star), R(0),

+ B(Nop),

B(JumpIfToBooleanFalse), U8(4),

B(LdaSmi), U8(3),

B(Return),

@@ -99,11 +101,12 @@ snippet: "

frame size: 1

parameter count: 1

-bytecode array length: 9

+bytecode array length: 10

bytecodes: [

B(StackCheck),

B(LdaZero),

B(Star), R(0),

+ B(Nop),

B(JumpIfToBooleanTrue), U8(4),

B(LdaSmi), U8(3),

B(Return),

@@ -119,7 +122,7 @@ snippet: "

frame size: 3

parameter count: 1

-bytecode array length: 32

+bytecode array length: 24

bytecodes: [

B(StackCheck),

B(LdaSmi), U8(2),

@@ -129,11 +132,7 @@ bytecodes: [

B(LdaSmi), U8(4),

B(Star), R(2),

B(Ldar), R(0),

- B(JumpIfToBooleanTrue), U8(16),

- B(Ldar), R(0),

- B(Ldar), R(1),

- B(Ldar), R(0),

- B(Ldar), R(1),

+ B(JumpIfToBooleanTrue), U8(8),

B(LdaSmi), U8(5),

B(Star), R(2),

B(LdaSmi), U8(3),

@@ -934,11 +933,12 @@ snippet: "

frame size: 1

parameter count: 1

-bytecode array length: 15

+bytecode array length: 16

bytecodes: [

B(StackCheck),

B(LdaSmi), U8(1),

B(Star), R(0),

+ B(Nop),

B(JumpIfToBooleanFalse), U8(4),

B(LdaSmi), U8(3),

B(JumpIfToBooleanTrue), U8(3),