chrome/app/generated_resources.grd - Issue 1947393004: add translate::kTranslateUI2016Q2 to chrome://flags page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 1947393004: add translate::kTranslateUI2016Q2 to chrome://flags page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 027021518cc844e88434876f0fad41611ca5118f..fd106fc4203b714143b6879f29b4bc56cdf25602 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -6377,6 +6377,12 @@ Keep your key file in a safe place. You will need it to create new versions of y

Enable the new Translate bubble UX is offered instead of the infobar.

</message>

</if>

+ <message name="IDS_FLAGS_TRANSLATE_2016Q2_UI_NAME" desc="Name of the flag to enable the Translate 2016Q2 UI.">

+ Translate 2016Q2 U

groby-ooo-7-16 2016/05/05 22:44:34 Please use a slightly more descriptive name :) M

ftang 2016/05/06 17:34:00 I am pretty against the use of word "New" to descr

+ </message>

+ <message name="IDS_FLAGS_TRANSLATE_2016Q2_UI_DESCRIPTION" desc="Description for the flag to enable the Translate 2016Q2 UI.">

+ Enable the Translate 2016Q2 UI design which show icon inside the bubble and new triggering logic.

groby-ooo-7-16 2016/05/05 22:44:34 You don't need to enumerate everything this does.

ftang 2016/05/06 17:34:00 Done.

+ </message>

Rect-based targeting in views

</message>

« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | chrome/browser/about_flags.cc » ('J')