Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 1947373003: Fix unit test crash caused by OSMesa not supporting rendering to GL_ALPHA8 (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLUtil.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
bsalomon
4 years, 7 months ago (2016-05-05 21:25:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947373003/1
4 years, 7 months ago (2016-05-05 21:25:10 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 7 months ago (2016-05-05 21:25:11 UTC) #6
robertphillips
lgtm
4 years, 7 months ago (2016-05-05 21:33:55 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 21:40:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4017007b288087c07c596baa9fe8ecf485bca1c3

Powered by Google App Engine
This is Rietveld 408576698