Source/core/animation/Keyframe.h - Issue 194733002: Web Animations: Use StringKeyframes for element.animate()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/Keyframe.h

Issue 194733002: Web Animations: Use StringKeyframes for element.animate() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/EffectInput.cpp ('K') | « Source/core/animation/EffectInput.cpp ('k') | Source/core/animation/KeyframeEffectModel.h » ('j') | Source/core/animation/StringKeyframe.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/Keyframe.h

diff --git a/Source/core/animation/Keyframe.h b/Source/core/animation/Keyframe.h

index 8b2075771b1105e935dfc0fbbe4da98441fd3ef5..2449894ee01b6da64bb4b1e21c59f1ef73154601 100644

--- a/Source/core/animation/Keyframe.h

+++ b/Source/core/animation/Keyframe.h

@@ -13,6 +13,8 @@ namespace WebCore {

typedef HashSet<CSSPropertyID> PropertySet;

+class Element;

// FIXME: Make Keyframe immutable

class Keyframe : public RefCountedWillBeGarbageCollectedFinalized<Keyframe> {

public:

@@ -55,7 +57,7 @@ public:

virtual bool isStringPropertySpecificKeyframe() const { return false; }

virtual PassOwnPtrWillBeRawPtr<PropertySpecificKeyframe> neutralKeyframe(double offset, PassRefPtr<TimingFunction> easing) const = 0;

- virtual PassRefPtrWillBeRawPtr<Interpolation> createInterpolation(CSSPropertyID, WebCore::Keyframe::PropertySpecificKeyframe* end) const = 0;

+ virtual PassRefPtrWillBeRawPtr<Interpolation> createInterpolation(CSSPropertyID, WebCore::Keyframe::PropertySpecificKeyframe* end, Element*) const = 0;

virtual void trace(Visitor*) = 0;