Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1947303002: Skip GpuCrash.GPUProcessCrashesExactlyOnce on all platforms. (Closed)

Created:
4 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 7 months ago
Reviewers:
danakj, sclittle
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip GpuCrash.GPUProcessCrashesExactlyOnce on all platforms. The assertion failure in Issue 608946 is firing frequently on the commit queue, and the flaky retry mechanism isn't working for this failure mode. BUG=608923, 608946 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=danakj@chromium.org, sclittle@chromium.org NOTRY=true Committed: https://crrev.com/0795777fbf9349b39b0c66704e5ce7633add15b8 Cr-Commit-Position: refs/heads/master@{#391712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/test/gpu/gpu_tests/context_lost_expectations.py View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Ken Russell (switch to Gerrit)
CQ'ing TBR'd and NOTRY=true. Tested locally.
4 years, 7 months ago (2016-05-05 00:14:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947303002/1
4 years, 7 months ago (2016-05-05 00:15:48 UTC) #6
sclittle
lgtm
4 years, 7 months ago (2016-05-05 00:16:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 00:24:22 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0795777fbf9349b39b0c66704e5ce7633add15b8 Cr-Commit-Position: refs/heads/master@{#391712}
4 years, 7 months ago (2016-05-05 00:26:08 UTC) #11
danakj
4 years, 7 months ago (2016-05-06 21:52:11 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1956703007/ by danakj@chromium.org.

The reason for reverting is: Temporary fix here:
https://codereview.chromium.org/1949753007/

More work to come..

Powered by Google App Engine
This is Rietveld 408576698