Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1947283002:
DevTools: [LiveSASS] make selectors and medias read-only for sass rules (Closed)
|
Created:
4 years, 7 months ago by lushnikov Modified:
4 years, 7 months ago CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: [LiveSASS] make selectors and medias read-only for sass rules
This patch:
- makes medias non-editable for SASS rules
- makes selectors non-editable for SASS rules
- removes "insert new rule" button for SASS rules
BUG=608102
R=pfeldman
Committed: https://crrev.com/f397f1ab027512743a0e3c5dd5349d75990b7bdb
Cr-Commit-Position: refs/heads/master@{#391928}
Patch Set 1 #
Total comments: 1
Patch Set 2 : address comments #Messages
Total messages: 21 (10 generated)
please, take a look! Screenshot: http://i.imgur.com/EziqVbA.png
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947283002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== DevTools: [LiveSASS] make selectors and medias read-only for sass rules BUG=608102 R=pfeldman ========== to ========== DevTools: [LiveSASS] make selectors and medias read-only for sass rules BUG=608102 R=pfeldman ==========
lushnikov@chromium.org changed reviewers: + paulirish@chromium.org
https://codereview.chromium.org/1947283002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css (right): https://codereview.chromium.org/1947283002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css:247: } I think we can leave off these styles completely. editability of selectors isn't that important so we dont need a visual affordance in this case. The feedback for people that try will be fine.
Description was changed from ========== DevTools: [LiveSASS] make selectors and medias read-only for sass rules BUG=608102 R=pfeldman ========== to ========== DevTools: [LiveSASS] make selectors and medias read-only for sass rules This patch: - makes medias non-editable for SASS rules - makes selectors non-editable for SASS rules - removes "insert new rule" button for SASS rules BUG=608102 R=pfeldman ==========
Ok, I removed any visual indication that something's not editable. This patch makes the following changes for SASS rules: - makes selectors read-only - makes medias read-only - removes "insert new rule" button Please, take another look!
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947283002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947283002/20001
Message was sent while issue was closed.
Description was changed from ========== DevTools: [LiveSASS] make selectors and medias read-only for sass rules This patch: - makes medias non-editable for SASS rules - makes selectors non-editable for SASS rules - removes "insert new rule" button for SASS rules BUG=608102 R=pfeldman ========== to ========== DevTools: [LiveSASS] make selectors and medias read-only for sass rules This patch: - makes medias non-editable for SASS rules - makes selectors non-editable for SASS rules - removes "insert new rule" button for SASS rules BUG=608102 R=pfeldman ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: [LiveSASS] make selectors and medias read-only for sass rules This patch: - makes medias non-editable for SASS rules - makes selectors non-editable for SASS rules - removes "insert new rule" button for SASS rules BUG=608102 R=pfeldman ========== to ========== DevTools: [LiveSASS] make selectors and medias read-only for sass rules This patch: - makes medias non-editable for SASS rules - makes selectors non-editable for SASS rules - removes "insert new rule" button for SASS rules BUG=608102 R=pfeldman Committed: https://crrev.com/f397f1ab027512743a0e3c5dd5349d75990b7bdb Cr-Commit-Position: refs/heads/master@{#391928} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f397f1ab027512743a0e3c5dd5349d75990b7bdb Cr-Commit-Position: refs/heads/master@{#391928} |
