content/browser/web_contents/web_contents_impl.h - Issue 1947263004: Introduces a new MHTML generation parameter specifying different behvaior for cache-control headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1947263004: Introduces a new MHTML generation parameter specifying different behvaior for cache-control headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Now with const cache-control accessors. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/mhtml_generation_manager.cc ('K') | « content/browser/download/save_package.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/public/common/mhtml_generation.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index bcf01b6244a8ab8e11b1b48f8480feec7813ce81..f4bc907e2bd91e9dba757b02c8f1cc645d0fac7e 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -83,6 +83,7 @@ struct AXEventNotificationDetails;

struct ColorSuggestion;

struct FaviconURL;

struct LoadNotificationDetails;

+struct MHTMLGenerationParams;

struct ResourceRedirectDetails;

struct ResourceRequestDetails;

@@ -355,8 +356,7 @@ class CONTENT_EXPORT WebContentsImpl

void SaveFrameWithHeaders(const GURL& url,

const Referrer& referrer,

const std::string& headers) override;

- void GenerateMHTML(const base::FilePath& file,

- bool use_binary_encoding,

+ void GenerateMHTML(const MHTMLGenerationParams& params,

const base::Callback<void(int64_t)>& callback) override;

const std::string& GetContentsMimeType() const override;

bool WillNotifyDisconnection() const override;