chrome/browser/extensions/api/page_capture/page_capture_api.cc - Issue 1947263004: Introduces a new MHTML generation parameter specifying different behvaior for cache-control headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/page_capture/page_capture_api.cc

Issue 1947263004: Introduces a new MHTML generation parameter specifying different behvaior for cache-control headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Work on compile. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc ('k') | content/browser/download/mhtml_generation_browsertest.cc » ('j') | content/browser/download/mhtml_generation_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/page_capture/page_capture_api.cc

diff --git a/chrome/browser/extensions/api/page_capture/page_capture_api.cc b/chrome/browser/extensions/api/page_capture/page_capture_api.cc

index cb3d1a32bc268d5453013379f4918fbf1752a7b7..a61b6edbee5473e2e2833fca724e1f2a5ab5e0c1 100644

--- a/chrome/browser/extensions/api/page_capture/page_capture_api.cc

+++ b/chrome/browser/extensions/api/page_capture/page_capture_api.cc

@@ -18,6 +18,7 @@

#include "content/public/browser/render_frame_host.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/common/mhtml_generation.h"

#include "extensions/common/extension_messages.h"

using content::BrowserThread;

@@ -132,8 +133,7 @@ void PageCaptureSaveAsMHTMLFunction::TemporaryFileCreated(bool success) {

}

web_contents->GenerateMHTML(

- mhtml_path_,

- false /* use_binary_encoding */,

+ content::MHTMLGenerationParams(mhtml_path_),

base::Bind(&PageCaptureSaveAsMHTMLFunction::MHTMLGenerated, this));

}