android_webview/native/aw_contents.cc - Issue 1947263004: Introduces a new MHTML generation parameter specifying different behvaior for cache-control headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.cc

Issue 1947263004: Introduces a new MHTML generation parameter specifying different behvaior for cache-control headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Work on compile. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc » ('j') | content/browser/download/mhtml_generation_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents.cc

diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc

index 77e35efbe3cba8f86c7d48bec6d05404d65fc5ae..8566a671bb8ed9ac9c208ef660a0b71265ace05a 100644

--- a/android_webview/native/aw_contents.cc

+++ b/android_webview/native/aw_contents.cc

@@ -69,6 +69,7 @@

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

#include "content/public/common/message_port_types.h"

+#include "content/public/common/mhtml_generation.h"

#include "content/public/common/renderer_preferences.h"

#include "content/public/common/ssl_status.h"

#include "jni/AwContents_jni.h"

@@ -404,8 +405,7 @@ void AwContents::GenerateMHTML(JNIEnv* env,

j_callback->Reset(env, callback);

base::FilePath target_path(ConvertJavaStringToUTF8(env, jpath));

web_contents_->GenerateMHTML(

- target_path,

- false /* use_binary_encoding */,

+ content::MHTMLGenerationParams(target_path),

base::Bind(&GenerateMHTMLCallback, base::Owned(j_callback), target_path));

}