Introduces a new MHTML generation parameter specifying different behvaior for cache-control headers.

third_party/WebKit/Source/web/WebFrameSerializer.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 29 matching lines @@
 #include "core/html/HTMLAllCollection.h"
 #include "core/html/HTMLFrameElementBase.h"
 #include "core/html/HTMLFrameOwnerElement.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLTableElement.h"
 #include "core/loader/DocumentLoader.h"
 #include "platform/SerializedResource.h"
 #include "platform/SharedBuffer.h"
 #include "platform/mhtml/MHTMLArchive.h"
 #include "platform/mhtml/MHTMLParser.h"
+#include "platform/network/ResourceResponse.h"
 #include "platform/weborigin/KURL.h"
 #include "public/platform/WebString.h"
 #include "public/platform/WebURL.h"
+#include "public/platform/WebURLResponse.h"
 #include "public/platform/WebVector.h"
+#include "public/web/WebDataSource.h"
 #include "public/web/WebDocument.h"
 #include "public/web/WebFrame.h"
 #include "public/web/WebFrameSerializerClient.h"
 #include "web/WebFrameSerializerImpl.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebRemoteFrameImpl.h"
 #include "wtf/Assertions.h"
 #include "wtf/HashMap.h"
 #include "wtf/HashSet.h"
 #include "wtf/Noncopyable.h"
@@ skipping 65 matching lines @@
     }
 
     return false;
 }
 
 bool MHTMLFrameSerializerDelegate::shouldSkipResource(const KURL& url)
 {
     return m_webDelegate.shouldSkipResource(url);
 }
 
+bool resourceResponseContainsNoStore(const ResourceResponse& response)
+{
+    DEFINE_STATIC_LOCAL(const AtomicString, cacheControlHeader, ("cache-control"));
+    DEFINE_STATIC_LOCAL(const AtomicString, pragmaHeader, ("pragma"));
+
+    return parseCacheControlDirectives(
+        response.httpHeaderField(cacheControlHeader),
+        response.httpHeaderField(pragmaHeader)).containsNoStore;

[Łukasz Anforowicz, 2016/05/12 18:56:49]

Could this be written as:
return response.cacheControlContainsNoStore();
?

[dewittj, 2016/05/12 22:58:01]

No, that method is not const, since it caches the results of parsing the cache
control header.

I was unable to figure out a way to get a non-const ResourceResponse; if you
have ideas I'd be glad to hear!

[Łukasz Anforowicz, 2016/05/12 23:56:27]

Oh, indeed - thanks for the explanation.  And I see that this constness problem
also happens in the Blink's core layer (i.e. blink::DocumentLoader::response()
returns a const-ref to ResourceResponse).

I hope that Blink owners can help here - it feels weird (wrong?) to me to repeat
the parsing call here, but maybe it is okay, given constness constraints?

[dcheng, 2016/05/13 17:48:33]

+toyoshim, +hiroshige: any ideas on how to improve this so we don't need to
manually reparse here?

[hiroshige, 2016/05/13 18:01:52]

How about making ResourceResponse::cacheControlContainsNoCache() and similar
methods to be const by making |ResourceResponse::m_cacheControlHeader| mutable,
and calling response.cacheControlContainsNoStore() here?

+}
+
 } // namespace
 
-WebData WebFrameSerializer::generateMHTMLHeader(
-    const WebString& boundary, WebLocalFrame* frame)
+bool WebFrameSerializer::generateMHTMLHeader(
+    const WebString& boundary, CacheControlPolicy cacheControlPolicy,
+    WebLocalFrame* frame, WebData* data)
 {
-    Document* document = toWebLocalFrameImpl(frame)->frame()->document();
+    WebLocalFrameImpl* webLocalFrameImpl = toWebLocalFrameImpl(frame);
+    DCHECK(webLocalFrameImpl);
+
+    const ResourceResponse& response = webLocalFrameImpl->dataSource()->response().toResourceResponse();
+    if (cacheControlPolicy == CacheControlPolicyFailForNoStoreMainFrame && resourceResponseContainsNoStore(response))
+        return false;
+
+    Document* document = webLocalFrameImpl->frame()->document();
 
     RefPtr<SharedBuffer> buffer = SharedBuffer::create();
     MHTMLArchive::generateMHTMLHeader(
         boundary, document->title(), document->suggestedMIMEType(),
         *buffer);
-    return buffer.release();
+    *data = buffer.release();
+    return true;
 }
 
 WebData WebFrameSerializer::generateMHTMLParts(
     const WebString& boundary, WebLocalFrame* webFrame, bool useBinaryEncoding,
     MHTMLPartsGenerationDelegate* webDelegate)
 {
     DCHECK(webFrame);
     DCHECK(webDelegate);
 
     // Translate arguments from public to internal blink APIs.
@@ skipping 62 matching lines @@
 WebString WebFrameSerializer::generateBaseTagDeclaration(const WebString& baseTarget)
 {
     // TODO(yosin) We should call |FrameSerializer::baseTagDeclarationOf()|.
     if (baseTarget.isEmpty())
         return String("<base href=\".\">");
     String baseString = "<base href=\".\" target=\"" + static_cast<const String&>(baseTarget) + "\">";
     return baseString;
 }
 
 } // namespace blink