Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 1947263003: Pin the snippets to the bottom of the page and introduce a peeking card to indicate to the user the… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
index 971f58506ebf153d1bc9986aeb244c7711b2207e..4206dedd7df0a87a965a6ac93766d0813c976e57 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
@@ -77,7 +77,6 @@ public class NewTabPageAdapter extends Adapter<NewTabPageViewHolder> implements
mItemTouchCallbacks = new ItemTouchCallbacks();
mNewTabPageListItems = new ArrayList<NewTabPageListItem>();
mNewTabPageListItems.add(mAboveTheFoldListItem);
-
mNewTabPageManager.setSnippetsObserver(this);
}
@@ -106,7 +105,10 @@ public class NewTabPageAdapter extends Adapter<NewTabPageViewHolder> implements
mNewTabPageListItems.clear();
mNewTabPageListItems.add(mAboveTheFoldListItem);
- mNewTabPageListItems.add(new SnippetHeaderListItem());
+ // Remove this for now as we need to come up with a better way to visibly not affect the
May 2016/05/05 16:28:22 add a //TODO
mcwilliams 2016/05/05 17:39:47 Done.
+ // layout of the page when not shown as currently pixels are allocated even though
+ // visibility is set to GONE.
Bernhard Bauer 2016/05/05 16:46:04 Please add a TODO to address this.
mcwilliams 2016/05/05 17:39:47 Done.
+ // mNewTabPageListItems.add(new SnippetHeaderListItem());
PEConn 2016/05/05 16:31:28 Change this to a TODO (and get rid of the commente
mcwilliams 2016/05/05 17:39:47 Done.
mNewTabPageListItems.addAll(listSnippets);
notifyDataSetChanged();

Powered by Google App Engine
This is Rietveld 408576698