chrome/android/java/res/values/dimens.xml - Issue 1947263003: Pin the snippets to the bottom of the page and introduce a peeking card to indicate to the user the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 1947263003: Pin the snippets to the bottom of the page and introduce a peeking card to indicate to the user the… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/new_tab_page_snippets_card.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/values/dimens.xml

diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml

index bbb422f1ac7f6030b8a92e90ab01bb56a80e98f5..f90ed4fbf556d051010b07555de715a86d012bb6 100644

--- a/chrome/android/java/res/values/dimens.xml

+++ b/chrome/android/java/res/values/dimens.xml

@@ -259,6 +259,8 @@

+ <dimen name="snippets_vertical_space">2dp</dimen>

Bernhard Bauer 2016/05/05 16:46:04 Is this used?

mcwilliams 2016/05/05 17:39:46 Done.

+ <dimen name="snippets_padding_and_peeking_card_height">16dp</dimen>