chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java - Issue 1947263003: Pin the snippets to the bottom of the page and introduce a peeking card to indicate to the user the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java

Issue 1947263003: Pin the snippets to the bottom of the page and introduce a peeking card to indicate to the user the… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java

index fe3e978c607cf2a8585f97f0aab46d3b144d9c08..cd28fe49a8149a5097a2eeffac0883c292766c11 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java

@@ -84,15 +84,6 @@ public class NewTabPageScrollView extends ScrollView {

}

@Override

- protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {

- if (mNewTabPageLayout != null) {

- mNewTabPageLayout.setParentScrollViewportHeight(

- MeasureSpec.getSize(heightMeasureSpec));

- }

- super.onMeasure(widthMeasureSpec, heightMeasureSpec);

- }

- @Override

public boolean onInterceptTouchEvent(MotionEvent ev) {

mGestureDetector.onTouchEvent(ev);

return super.onInterceptTouchEvent(ev);