[Offline pages] Implementation of RequestQueue: Add, Remove, Get

[Offline pages] Implementation of RequestQueue: Add, Remove, Get

Basic implementation of request queue:
* Add request
* Remove request
* Get requests
* injecting store in ctor
* Tests for above with exception of cases, where store issues an error.

BUG=607221
R=dougarnett@chromium.org,petewil@chromium.org

Committed: https://crrev.com/124c9275001c8070dd774941e8d82afb3fdabe01
Cr-Commit-Position: refs/heads/master@{#391910}

[fgorski, 2016-05-04 22:01:05]

PTAL.

This is how far I was able to get today with request queue.

[Pete Williamson, 2016-05-04 23:10:51]

https://codereview.chromium.org/1947253002/diff/20001/components/offline_page...
File components/offline_pages/background/request_queue_unittest.cc (right):

https://codereview.chromium.org/1947253002/diff/20001/components/offline_page...
components/offline_pages/background/request_queue_unittest.cc:138: 
Can we add a test case with several results in the vector for GetRequests?

https://codereview.chromium.org/1947253002/diff/20001/components/offline_page...
components/offline_pages/background/request_queue_unittest.cc:161: 
It would be nice to have a test with three elements in the store, and make sure
remove removed the correct one, and left the others.

[dougarnett, 2016-05-05 16:12:00]

lgtm

[fgorski, 2016-05-05 16:51:52]

Pete, ptal

https://codereview.chromium.org/1947253002/diff/20001/components/offline_page...
File components/offline_pages/background/request_queue_unittest.cc (right):

https://codereview.chromium.org/1947253002/diff/20001/components/offline_page...
components/offline_pages/background/request_queue_unittest.cc:138: 
On 2016/05/04 23:10:50, Pete Williamson wrote:
> Can we add a test case with several results in the vector for GetRequests?

Done.

https://codereview.chromium.org/1947253002/diff/20001/components/offline_page...
components/offline_pages/background/request_queue_unittest.cc:161: 
On 2016/05/04 23:10:50, Pete Williamson wrote:
> It would be nice to have a test with three elements in the store, and make
sure
> remove removed the correct one, and left the others. 

Done. I went with one test with 2 elements.

[Pete Williamson, 2016-05-05 16:58:01]

lgtm with nit.

https://codereview.chromium.org/1947253002/diff/40001/components/offline_page...
File components/offline_pages/background/request_queue_unittest.cc (right):

https://codereview.chromium.org/1947253002/diff/40001/components/offline_page...
components/offline_pages/background/request_queue_unittest.cc:170: 77,
GURL("http://test.com"), ClientId("bookmark", "567"), creation_time);
Can we move these constants to the top of the file with the others?

[fgorski, 2016-05-05 17:48:32]

addressed. Fixing compilation issue and this is ready to go.

https://codereview.chromium.org/1947253002/diff/40001/components/offline_page...
File components/offline_pages/background/request_queue_unittest.cc (right):

https://codereview.chromium.org/1947253002/diff/40001/components/offline_page...
components/offline_pages/background/request_queue_unittest.cc:170: 77,
GURL("http://test.com"), ClientId("bookmark", "567"), creation_time);
On 2016/05/05 16:58:00, Pete Williamson wrote:
> Can we move these constants to the top of the file with the others?

Done.

[fgorski, 2016-05-05 20:23:38]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-05-05 20:23:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
dougarnett@chromium.org, petewil@chromium.org
Link to the patchset: https://codereview.chromium.org/1947253002/#ps100001
(title: "removing optional")

[commit-bot: I haz the power, 2016-05-05 20:24:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947253002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947253002/100001

[commit-bot: I haz the power, 2016-05-05 21:38:09]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-05 21:41:02]

Description was changed from

==========
[Offline pages] Implementation of RequestQueue: Add, Remove, Get

Basic implementation of request queue:
* Add request
* Remove request
* Get requests
* injecting store in ctor
* Tests for above with exception of cases, where store issues an error.

BUG=607221
R=dougarnett@chromium.org,petewil@chromium.org
==========

to

==========
[Offline pages] Implementation of RequestQueue: Add, Remove, Get

Basic implementation of request queue:
* Add request
* Remove request
* Get requests
* injecting store in ctor
* Tests for above with exception of cases, where store issues an error.

BUG=607221
R=dougarnett@chromium.org,petewil@chromium.org

Committed: https://crrev.com/124c9275001c8070dd774941e8d82afb3fdabe01
Cr-Commit-Position: refs/heads/master@{#391910}
==========

[commit-bot: I haz the power, 2016-05-05 21:41:03]

Patchset 6 (id:??) landed as
https://crrev.com/124c9275001c8070dd774941e8d82afb3fdabe01
Cr-Commit-Position: refs/heads/master@{#391910}