Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1947223003: Tell clang-cl to use POSIX quoting for response files when running on non-Windows hosts. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tell clang-cl to use POSIX quoting for response files on non-Windows hosts. gn always quotes arguments using the host rules. No behavior change except when targeting Windows from non-Windows hosts, which isn't allowed yet in build/config/BUILDCONFIG.gn BUG=600223 Committed: https://crrev.com/6bcb18bfa6f9a7bbc3f9fa4cc3953d0a215eaac5 Cr-Commit-Position: refs/heads/master@{#391892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M build/toolchain/win/BUILD.gn View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Nico
4 years, 7 months ago (2016-05-05 18:01:20 UTC) #3
brettw
lgtm
4 years, 7 months ago (2016-05-05 19:49:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947223003/1
4 years, 7 months ago (2016-05-05 19:54:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 20:24:02 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 20:25:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bcb18bfa6f9a7bbc3f9fa4cc3953d0a215eaac5
Cr-Commit-Position: refs/heads/master@{#391892}

Powered by Google App Engine
This is Rietveld 408576698