Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1947183004: Move about half of the clang/win bots to gn. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Reid Kleckner
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move about half of the clang/win bots to gn. The CrWinClang64(dbg) bot already is on gn. After this change, the following bots will be on gn: Pinned: CrWinClang CrWinClang(shared) CrWinClang64(dbg) (already on gn) ToT: ClangToTWin(dll) ClangToTWin64 ClangToTWin64(dll) These complement each other, so that each of - 32-bit release static official - 32-bit release shared - 32-bit debug shared - 64-bit release static official - 64-bit release shared - 64-bit debug shared has one gyp and one gn bot (one a ToT bot, the other a pinned bot, respectively). I'll also switch one of the ASan bots, but that's for a separate CL. Hopefully, no behavior change. BUG=498033 R=dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/dafacdab8ad432c98028eff432c09360f28254fe

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M tools/mb/mb_config.pyl View 8 chunks +15 lines, -15 lines 1 comment Download

Messages

Total messages: 13 (4 generated)
Nico
4 years, 7 months ago (2016-05-05 20:07:23 UTC) #2
Dirk Pranke
lgtm w/ sorting addressed, if you'd be so kind. https://codereview.chromium.org/1947183004/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1947183004/diff/1/tools/mb/mb_config.pyl#newcode1682 tools/mb/mb_config.pyl:1682: ...
4 years, 7 months ago (2016-05-05 20:30:24 UTC) #3
Nico
Is there some script I can run to sort? Or do you want me to ...
4 years, 7 months ago (2016-05-05 20:31:55 UTC) #4
Dirk Pranke
On 2016/05/05 20:31:55, Nico wrote: > Is there some script I can run to sort? ...
4 years, 7 months ago (2016-05-05 20:36:06 UTC) #5
Nico
Hm, I'll do it in a separate CL, else the diff will be really hard ...
4 years, 7 months ago (2016-05-05 20:38:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947183004/1
4 years, 7 months ago (2016-05-05 20:39:06 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dafacdab8ad432c98028eff432c09360f28254fe Cr-Commit-Position: refs/heads/master@{#391917}
4 years, 7 months ago (2016-05-05 21:46:35 UTC) #10
Nico
Committed patchset #1 (id:1) manually as dafacdab8ad432c98028eff432c09360f28254fe (presubmit successful).
4 years, 7 months ago (2016-05-05 21:47:25 UTC) #12
Nico
4 years, 7 months ago (2016-05-06 01:20:34 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1948303003/ by thakis@chromium.org.

The reason for reverting is: 32-bit builds fail like so:
obj/chrome/installer/mini_installer/lib/chrome_appid.obj : fatal error LNK1112:
module machine type 'x64' conflicts with target machine type 'X86'

(The 64-bit bots look fine though.).

Powered by Google App Engine
This is Rietveld 408576698