Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1947173002: Update //device/bluetooth/dbus code to match cros_system_api constants. (Closed)

Created:
4 years, 7 months ago by rkc
Modified:
4 years, 7 months ago
Reviewers:
scheib
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update //device/bluetooth/dbus code to match cros_system_api constants. The method name for GATT service registration has changed in BlueZ. We've rolled the cros_system_api constants to match. This CL updates the GATT manager client code to reflect that. Since this is a required but miniscule mechanical change, TBRing. TBR=scheib@chromium.org BUG=600655 Committed: https://crrev.com/ced897af4ba797e3824a615b847701cbe80e0c95 Cr-Commit-Position: refs/heads/master@{#391596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M device/bluetooth/dbus/bluetooth_gatt_manager_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rkc
4 years, 7 months ago (2016-05-04 17:59:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947173002/1
4 years, 7 months ago (2016-05-04 18:00:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 19:17:36 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ced897af4ba797e3824a615b847701cbe80e0c95 Cr-Commit-Position: refs/heads/master@{#391596}
4 years, 7 months ago (2016-05-04 19:19:33 UTC) #6
scheib
LGTM, Note, this is not TBR appropriate, see: http://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Reviewed-TBR-
4 years, 7 months ago (2016-05-04 22:43:16 UTC) #7
rkc
4 years, 7 months ago (2016-05-04 22:44:10 UTC) #8
Message was sent while issue was closed.
Ah. I apologize, I'll not TBR next time.

Powered by Google App Engine
This is Rietveld 408576698