Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 1947143003: DevTools: make throttler with timeout respect the timeout. (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
caseq, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: make throttler with timeout respect the timeout. Committed: https://crrev.com/f2b80138ce5debef0b6d479862445b0b268fe3a9 Cr-Commit-Position: refs/heads/master@{#391764}

Patch Set 1 #

Total comments: 2

Patch Set 2 : tests fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/components/throttler-expected.txt View 1 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Throttler.js View 1 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
pfeldman
4 years, 7 months ago (2016-05-05 01:35:34 UTC) #2
pfeldman
4 years, 7 months ago (2016-05-05 01:36:07 UTC) #4
caseq
lgtm https://codereview.chromium.org/1947143003/diff/1/third_party/WebKit/Source/devtools/front_end/common/Throttler.js File third_party/WebKit/Source/devtools/front_end/common/Throttler.js (right): https://codereview.chromium.org/1947143003/diff/1/third_party/WebKit/Source/devtools/front_end/common/Throttler.js#newcode22 third_party/WebKit/Source/devtools/front_end/common/Throttler.js:22: this._lastCompleteTime = Date.now(); performance.now() * 1000? https://codereview.chromium.org/1947143003/diff/1/third_party/WebKit/Source/devtools/front_end/common/Throttler.js#newcode58 third_party/WebKit/Source/devtools/front_end/common/Throttler.js:58: ...
4 years, 7 months ago (2016-05-05 01:39:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947143003/1
4 years, 7 months ago (2016-05-05 02:02:48 UTC) #7
lushnikov
lgtm
4 years, 7 months ago (2016-05-05 02:20:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/216658)
4 years, 7 months ago (2016-05-05 03:13:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947143003/20001
4 years, 7 months ago (2016-05-05 04:09:46 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-05 05:20:11 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 05:21:46 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f2b80138ce5debef0b6d479862445b0b268fe3a9
Cr-Commit-Position: refs/heads/master@{#391764}

Powered by Google App Engine
This is Rietveld 408576698