Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 1947143002: Revert of Allow stencils to be attached to render targets created via SkSurface::MakeFromBackendTextureAsRend… (Closed)

Created:
4 years, 7 months ago by jvanverth1
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Allow stencils to be attached to render targets created via SkSurface::MakeFromBackendTextureAsRend… (patchset #1 id:60001 of https://codereview.chromium.org/1941353003/ ) Reason for revert: Breaking the ANGLE bots. Message is: Caught exception 3221225477 EXCEPTION_ACCESS_VIOLATION 8.59m elapsed, 1 active, 82 queued, 315MB RAM, 1442MB peak unit test SurfaceAttachStencil_Gpu step returned non-zero exit code: -1073741819 Original issue's description: > Allow stencils to be attached to render targets created via SkSurface::MakeFromBackendTextureAsRenderTarget > > This is a regression from "Refactor to separate backend object lifecycle > and GpuResource budget decision". > > GrGLRenderer::canAttemptStencilAttachment was incorrectly returning false > for all wrapped render targets. This function should return false only if > the FBO is wrapped (unowned). If the FBO is owned by Skia, we can attach > stencils. > > BUG=608238 > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924183003 > > Committed: https://skia.googlesource.com/skia/+/0736f3386820f19c0fe90b5dda2094e253780071 TBR=bsalomon@google.com,kkinnunen@nvidia.com,ericrk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608238 Committed: https://skia.googlesource.com/skia/+/31f25a037d7e3ee9de8f26e8cdd5c1f88da0f765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -157 lines) Patch
M src/gpu/gl/GrGLRenderTarget.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/SurfaceTest.cpp View 6 chunks +97 lines, -155 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jvanverth1
4 years, 7 months ago (2016-05-04 17:08:00 UTC) #1
Created Revert of Allow stencils to be attached to render targets created via
SkSurface::MakeFromBackendTextureAsRend…

Powered by Google App Engine
This is Rietveld 408576698