Chromium Code Reviews| Index: chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc |
| diff --git a/chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc b/chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc |
| index 27d7b0f95c5a578177d900c23d81c0e86f394d58..cad6f93c54800bab46cc40fd7616295ef8f393cc 100644 |
| --- a/chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc |
| +++ b/chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc |
| @@ -89,8 +89,15 @@ static base::FilePath GetTestDataDir() { |
| // 50 / 100 in level. Also go into the playback tab, right-click Speakers, |
| // and set that level to 50 / 100. Otherwise you will get distortion in |
| // the recording. |
| -class WebRtcAudioQualityBrowserTest : public WebRtcTestBase { |
| +class WebRtcAudioQualityBrowserTest : public WebRtcTestBase, |
| + public testing::WithParamInterface<bool> { |
| public: |
| + WebRtcAudioQualityBrowserTest() { |
| + if (GetParam()) { |
|
phoglund_chromium
2014/03/12 17:27:18
bool enable_audio_track_processing = GetParam() to
no longer working on chromium
2014/03/12 18:06:07
Done.
|
| + CommandLine::ForCurrentProcess()->AppendSwitch( |
|
phoglund_chromium
2014/03/12 17:27:18
Do this in SetupCommandLine below instead and act
no longer working on chromium
2014/03/12 18:06:08
I guess you meant SetUpCommandLine(CommandLine* co
|
| + switches::kEnableAudioTrackProcessing); |
| + } |
| + } |
| virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { |
| PeerConnectionServerRunner::KillAllPeerConnectionServersOnCurrentSystem(); |
| DetectErrorsInJavaScript(); // Look for errors in our rather complex js. |
| @@ -361,6 +368,11 @@ bool RunPesq(const base::FilePath& reference_file, |
| return true; |
| } |
| +static const bool kRunTestsWithFlag[] = { false, true }; |
| +INSTANTIATE_TEST_CASE_P(WebRtcAudioQualityBrowserTests, |
| + WebRtcAudioQualityBrowserTest, |
| + testing::ValuesIn(kRunTestsWithFlag)); |
| + |
| // Should be enabled for Linux, but is flaky. http://crbug.com/340197. |
| #if defined(OS_WIN) |
| // Only implemented on Linux and Windows for now. |
| @@ -369,7 +381,7 @@ bool RunPesq(const base::FilePath& reference_file, |
| #define MAYBE_MANUAL_TestAudioQuality DISABLED_MANUAL_TestAudioQuality |
| #endif |
| -IN_PROC_BROWSER_TEST_F(WebRtcAudioQualityBrowserTest, |
| +IN_PROC_BROWSER_TEST_P(WebRtcAudioQualityBrowserTest, |
| MAYBE_MANUAL_TestAudioQuality) { |
| #if defined(OS_WIN) |
| if (base::win::GetVersion() < base::win::VERSION_VISTA) { |