Source/core/rendering/RenderTable.cpp - Issue 194713009: Make sure table cells are laid out again when fragmentainer height changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTable.cpp

Issue 194713009: Make sure table cells are laid out again when fragmentainer height changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address code review issues raised together with the lgtm. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderTable.cpp

diff --git a/Source/core/rendering/RenderTable.cpp b/Source/core/rendering/RenderTable.cpp

index acc0f32b06482ffe1bc4c8592221b0677cbafdcf..d1b9224182b08c687bd278fb49459584927c19e7 100644

--- a/Source/core/rendering/RenderTable.cpp

+++ b/Source/core/rendering/RenderTable.cpp

@@ -458,6 +458,8 @@ void RenderTable::layout()

bool collapsing = collapseBorders();

for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {

+ if (!child->needsLayout() && child->isBox())

+ toRenderBox(child)->markForPaginationRelayoutIfNeeded(layouter);

if (child->isTableSection()) {

RenderTableSection* section = toRenderTableSection(child);

if (m_columnLogicalWidthChanged)

« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderTableRow.cpp » ('j') | no next file with comments »