LayoutTests/fast/multicol/table-cell-content-change.html - Issue 194713009: Make sure table cells are laid out again when fragmentainer height changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/table-cell-content-change.html

Issue 194713009: Make sure table cells are laid out again when fragmentainer height changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address code review issues raised together with the lgtm. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 function test() {

	6 document.body.offsetTop; // trigger layout

	7 document.getElementById('elm').style.display = 'block';

	8 }

	9 </script>

	10 </head>

	11 <body onload="test()">

	12 <h3>Changing the contents of a table cell, increasing column height</h3>

	13

	14 <p>You should see the text "first column" once in the first column, and the text "second

	15 column" twice in the second column.</p>

	16 <div style="-webkit-columns:2; columns:2; x-webkit-column-rule:1px solid ; xcolumn-rule:1px solid; orphans:1; widows:1; xbackground:yellow;"> <!-- FIXME: should ideally paint background and column rules here, to measure the column he ight, but the balancing machinery in the old multicol implementation doesn't do it properly. See crbug.com/352052 -->

	17 <div style="display:table-row;">

	18 first column

	19 <div style="height:0.1em;"></div>

	20 </div>

	21 <div style="display:table-row;">

	22 second column

	23 <div id="elm" style="display:none;">second column</div>

	24 </div>

	25 </div>

	26 </body>

	27 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/table-cell-content-change-expected.html » ('j') | no next file with comments »