LayoutTests/fast/multicol/table-cell-content-change-expected.html - Issue 194713009: Make sure table cells are laid out again when fragmentainer height changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/table-cell-content-change-expected.html

Issue 194713009: Make sure table cells are laid out again when fragmentainer height changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address code review issues raised together with the lgtm. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <h3>Changing the contents of a table cell, increasing column height</h3>

	5

	6 <p>You should see the text "first column" once in the first column, and the text "second

	7 column" twice in the second column.</p>

	8 <div style="-webkit-columns:2; columns:2; x-webkit-column-rule:1px solid ; xcolumn-rule:1px solid; orphans:1; widows:1; xbackground:yellow;"> <!-- FIXME: should ideally paint background and column rules here, to measure the column he ight, but the balancing machinery in the old multicol implementation doesn't do it properly. See crbug.com/352052 -->

	9 first column<br>

	10 <br>

	11 second column<br>

	12 second column

	13 </div>

	14 </body>

	15 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/fast/multicol/table-cell-content-change.html ('k') | Source/core/rendering/RenderBox.h » ('j') | no next file with comments »