Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Side by Side Diff: Source/devtools/front_end/FlameChart.js

Issue 194713007: TimelinePanel: restore selectedRecord behevior by removing windowFilter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /** 1 /**
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 967 matching lines...) Expand 10 before | Expand all | Expand 10 after
978 if (element.parentElement) 978 if (element.parentElement)
979 element.remove(); 979 element.remove();
980 if (entryIndex === -1) 980 if (entryIndex === -1)
981 return; 981 return;
982 var timeRange = this._dataProvider.highlightTimeRange(entryIndex); 982 var timeRange = this._dataProvider.highlightTimeRange(entryIndex);
983 if (!timeRange) 983 if (!timeRange)
984 return; 984 return;
985 var timelineData = this._timelineData(); 985 var timelineData = this._timelineData();
986 var barX = this._offsetToPosition(timeRange.startTimeOffset); 986 var barX = this._offsetToPosition(timeRange.startTimeOffset);
987 var barRight = this._offsetToPosition(timeRange.endTimeOffset); 987 var barRight = this._offsetToPosition(timeRange.endTimeOffset);
988 if (barRight === 0 || barX === this._canvas.width)
989 return;
988 var barWidth = Math.max(barRight - barX, this._minWidth); 990 var barWidth = Math.max(barRight - barX, this._minWidth);
989 var barY = this._levelToHeight(timelineData.entryLevels[entryIndex]); 991 var barY = this._levelToHeight(timelineData.entryLevels[entryIndex]);
990 var style = element.style; 992 var style = element.style;
991 style.left = barX + "px"; 993 style.left = barX + "px";
992 style.top = barY + "px"; 994 style.top = barY + "px";
993 style.width = barWidth + "px"; 995 style.width = barWidth + "px";
994 style.height = this._barHeight + "px"; 996 style.height = this._barHeight + "px";
995 this.element.appendChild(element); 997 this.element.appendChild(element);
996 }, 998 },
997 999
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
1141 reset: function() 1143 reset: function()
1142 { 1144 {
1143 this._highlightedEntryIndex = -1; 1145 this._highlightedEntryIndex = -1;
1144 this._selectedEntryIndex = -1; 1146 this._selectedEntryIndex = -1;
1145 this._textWidth = {}; 1147 this._textWidth = {};
1146 this.update(); 1148 this.update();
1147 }, 1149 },
1148 1150
1149 __proto__: WebInspector.View.prototype 1151 __proto__: WebInspector.View.prototype
1150 } 1152 }
OLDNEW
« no previous file with comments | « LayoutTests/inspector/timeline/timeline-window-filter.html ('k') | Source/devtools/front_end/TimelinePanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698