Throw empty error from V8PromiseCustom

Throw empty error from V8PromiseCustom

Blink and the inspector cannot deal with a stack overflow exception
thrown from V8PromiseCustom.
As a workaround, V8PromiseCustom throws an empty error when some exception
is thrown.

BUG=345088
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169028

[yhirano, 2014-03-12 06:12:59]

PTAL

I think this is better than another one[1].
If you think [1] is better, please review it.

[1] https://codereview.chromium.org/194443004/

[haraken, 2014-03-12 06:18:43]

> As a workaround, V8PromiseCustom throws an empty error when some exception 
is thrown.

It looks like the CL is throwing nothing instead of throwing "an empty error".
Are you intending to "ignore" exceptions thrown by V8PromiseCustom?

[yhirano, 2014-03-12 06:28:14]

> It looks like the CL is throwing nothing instead of throwing "an empty error".
> Are you intending to "ignore" exceptions thrown by V8PromiseCustom?
Actually I want to throw another Error by using V8ThrowException::throwError or
something.
But when I do so the original StackOverFlow is thrown, ignoring my operation.
It seems catching an exception and throwing another exception is impossible from
the V8 public API.

Instead of that, If I return an empty value without throwing an exception, an
Error other than StackOverFlow is printed on the console and it works for me.

[dcarney, 2014-03-12 08:26:18]

lgtm, but i think this should be handled in the inspector and not like this

[yhirano, 2014-03-12 08:27:59]

On 2014/03/12 08:26:18, dcarney wrote:
> lgtm, but i think this should be handled in the inspector and not like this

Thanks, I land this for now and will seek a better way.

[yhirano, 2014-03-12 08:28:04]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-03-12 08:28:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/194713006/1

[commit-bot: I haz the power, 2014-03-12 08:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 08:29:38]

Try jobs failed on following builders: mac_blink_compile

[yhirano, 2014-03-12 08:32:23]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-03-12 08:32:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/194713006/1

[commit-bot: I haz the power, 2014-03-12 09:11:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 09:11:24]

Try jobs failed on following builders: win_blink_rel

[yhirano, 2014-03-12 09:11:41]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-03-12 09:11:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/194713006/1

[commit-bot: I haz the power, 2014-03-12 09:42:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 09:42:53]

Try jobs failed on following builders: linux_blink

[yhirano, 2014-03-12 13:11:40]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-03-12 13:11:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/194713006/1

[commit-bot: I haz the power, 2014-03-12 13:13:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 13:13:15]

Try jobs failed on following builders: linux_blink

[yhirano, 2014-03-12 14:58:11]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-03-12 14:58:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yhirano@chromium.org/194713006/1

[commit-bot: I haz the power, 2014-03-12 15:59:06]

Change committed as 169028