Enable 64-bit architectures by default for Xcode 5.1 and higher

Enable 64-bit architectures by default for Xcode 5.1 and higher

According to Xcode 5.1 release notes, the "Standard Architectures" build
settings now also include 64-bit architecture, while the build settings
"Standard Architectures Including 64-Bit" is no deprecated.

BUG=gyp:412
R=mark@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1882

[sdefresne, 2014-03-11 09:48:35]

Please take a look.

[Mark Mentovai, 2014-03-11 15:28:10]

Have you verified that Xcode 5.1 actually behaves as the release notes say, and
that it sets these variables the same way you’ve set them here?

[sdefresne, 2014-03-11 16:01:03]

On 2014/03/11 15:28:10, Mark Mentovai wrote:
> Have you verified that Xcode 5.1 actually behaves as the release notes say,
and
> that it sets these variables the same way you’ve set them here?

Yes, I've verified that with Xcode 5.1, $(ARCHS_STANDARD) includes "arm7",
"armv7" and "arm64" and that $(ARCHS_STANDARD_INCLUDING_64_BITS) has been
removed (and the project is converted to use ARCHS_STANDARD).

[Mark Mentovai, 2014-03-11 16:06:22]

Then should you remove ARCHS_STANDARD_INCLUDING_64_BIT from the new 5.1 code?

https://codereview.chromium.org/194713003/diff/1/pylib/gyp/xcode_emulation.py
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/194713003/diff/1/pylib/gyp/xcode_emulation.py...
pylib/gyp/xcode_emulation.py:949: # For new projects, ARCHS is set to
$(ARCHS_STANDARD_INCLUDING_64_BIT),
Fix?

[sdefresne, 2014-03-22 12:54:36]

Xcode 5.1 still understand $(ARCHS_STANDARD_INCLUDING_64_BIT) though it consider
it deprecated. I think we should still support it in xcode_emulation.py until
the support is completely removed from Xcode (5.2?).

Please take another look, and disregard patch set number 2. I tried to refactor
the code but ended up too ambitious.

https://codereview.chromium.org/194713003/diff/1/pylib/gyp/xcode_emulation.py
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/194713003/diff/1/pylib/gyp/xcode_emulation.py...
pylib/gyp/xcode_emulation.py:949: # For new projects, ARCHS is set to
$(ARCHS_STANDARD_INCLUDING_64_BIT),
On 2014/03/11 16:06:23, Mark Mentovai wrote:
> Fix?

Done.

[Mark Mentovai, 2014-03-22 13:55:49]

https://codereview.chromium.org/194713003/diff/40001/pylib/gyp/xcode_emulatio...
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/194713003/diff/40001/pylib/gyp/xcode_emulatio...
pylib/gyp/xcode_emulation.py:966: return 'i386'
Why not x86_64 too when version >= '0500'?

[sdefresne, 2014-03-24 10:52:21]

PTAL

https://codereview.chromium.org/194713003/diff/40001/pylib/gyp/xcode_emulatio...
File pylib/gyp/xcode_emulation.py (right):

https://codereview.chromium.org/194713003/diff/40001/pylib/gyp/xcode_emulatio...
pylib/gyp/xcode_emulation.py:966: return 'i386'
On 2014/03/22 13:55:50, Mark Mentovai wrote:
> Why not x86_64 too when version >= '0500'?

Done.

[Mark Mentovai, 2014-03-24 13:06:34]

LGTM

[sdefresne, 2014-03-24 13:37:25]

Committed patchset #4 manually as r1882 (presubmit successful).