Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: tools/gn/bin/roll_gn.py

Issue 1947123004: Remove reference to old gn win x64 bot in roll_gn.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2014 The Chromium Authors. All rights reserved. 2 # Copyright 2014 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """An auto-roller for GN binaries into Chromium. 6 """An auto-roller for GN binaries into Chromium.
7 7
8 This script is used to update the GN binaries that a Chromium 8 This script is used to update the GN binaries that a Chromium
9 checkout uses. In order to update the binaries, one must follow 9 checkout uses. In order to update the binaries, one must follow
10 four steps in order: 10 four steps in order:
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 return ( 425 return (
426 'Roll buildtools %s..%s\n' 426 'Roll buildtools %s..%s\n'
427 '\n' 427 '\n'
428 ' In order to roll GN %s..%s (r%s:r%s) and pick up\n' 428 ' In order to roll GN %s..%s (r%s:r%s) and pick up\n'
429 ' the following changes:\n' 429 ' the following changes:\n'
430 '\n' 430 '\n'
431 '%s' 431 '%s'
432 '\n' 432 '\n'
433 'TBR=%s\n' 433 'TBR=%s\n'
434 'CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;' 434 'CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;'
435 'tryserver.chromium.win:win8_chromium_gn_dbg,' 435 'tryserver.chromium.win:win8_chromium_gn_dbg\n' % (
436 'win_chromium_gn_x64_rel\n' % (
437 old_buildtools_commitish[:COMMITISH_DIGITS], 436 old_buildtools_commitish[:COMMITISH_DIGITS],
438 new_buildtools_commitish[:COMMITISH_DIGITS], 437 new_buildtools_commitish[:COMMITISH_DIGITS],
439 self.old_gn_commitish[:COMMITISH_DIGITS], 438 self.old_gn_commitish[:COMMITISH_DIGITS],
440 self.new_gn_commitish[:COMMITISH_DIGITS], 439 self.new_gn_commitish[:COMMITISH_DIGITS],
441 self.old_gn_version, 440 self.old_gn_version,
442 self.new_gn_version, 441 self.new_gn_version,
443 gn_changes, 442 gn_changes,
444 self.reviewer, 443 self.reviewer,
445 )) 444 ))
446 445
447 def GetGNChanges(self): 446 def GetGNChanges(self):
448 _, out, _ = self.Call( 447 _, out, _ = self.Call(
449 "git log --pretty=' %h %s' " + 448 "git log --pretty=' %h %s' " +
450 "%s..%s tools/gn" % (self.old_gn_commitish, self.new_gn_commitish)) 449 "%s..%s tools/gn" % (self.old_gn_commitish, self.new_gn_commitish))
451 return out 450 return out
452 451
453 def Call(self, cmd, cwd=None): 452 def Call(self, cmd, cwd=None):
454 proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, shell=True, 453 proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, shell=True,
455 cwd=(cwd or self.chromium_src_dir)) 454 cwd=(cwd or self.chromium_src_dir))
456 out, err = proc.communicate() 455 out, err = proc.communicate()
457 return proc.returncode, out, err 456 return proc.returncode, out, err
458 457
459 458
460 if __name__ == '__main__': 459 if __name__ == '__main__':
461 roller = GNRoller() 460 roller = GNRoller()
462 sys.exit(roller.Roll()) 461 sys.exit(roller.Roll())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698