Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1947103002: Fix LTO on Linux by not specifying a blacklist. (Closed)

Created:
4 years, 7 months ago by krasin
Modified:
4 years, 7 months ago
Reviewers:
Nico, pcc1
CC:
chromium-reviews, kcc2, Nico, hans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix LTO on Linux by not specifying a blacklist. The new Clang toolchain rolled yesterday makes LTO devirtualization working on visibility basis, instead of being based on a blacklist. This CL just removes the now unsupported option. BUG=601822 Committed: https://crrev.com/806f95f1974ea657e43b854c3ec30c2b59eca8b4 Cr-Commit-Position: refs/heads/master@{#391572}

Patch Set 1 #

Patch Set 2 : gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M build/common.gypi View 1 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
krasin
4 years, 7 months ago (2016-05-04 16:04:28 UTC) #2
pcc1
You also need to remove from gyp.
4 years, 7 months ago (2016-05-04 16:05:47 UTC) #3
Nico
I usually wait a day or two after landing things depending on a clang roll ...
4 years, 7 months ago (2016-05-04 16:07:29 UTC) #5
krasin
On 2016/05/04 16:05:47, pcc1 wrote: > You also need to remove from gyp. Done. PTAL
4 years, 7 months ago (2016-05-04 16:46:08 UTC) #6
krasin
On 2016/05/04 16:07:29, Nico (hiding Wed May 4) wrote: > I usually wait a day ...
4 years, 7 months ago (2016-05-04 16:48:31 UTC) #7
Nico
fair enough, lgtm then :-)
4 years, 7 months ago (2016-05-04 16:51:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947103002/20001
4 years, 7 months ago (2016-05-04 16:52:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 18:27:15 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 18:28:50 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/806f95f1974ea657e43b854c3ec30c2b59eca8b4
Cr-Commit-Position: refs/heads/master@{#391572}

Powered by Google App Engine
This is Rietveld 408576698