Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 19471016: message-center: Fix fling scroll in the list. (Closed)

Created:
7 years, 5 months ago by sadrul
Modified:
7 years, 5 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews
Visibility:
Public.

Description

message-center: Fix fling scroll in the list. BUG=263627 R=mukai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213335

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/message_center/views/message_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
7 years, 5 months ago (2013-07-24 00:10:31 UTC) #1
Jun Mukai
lgtm So it's in message_center... sigh. Thank you very much! (and sorry for blaming you)
7 years, 5 months ago (2013-07-24 00:22:22 UTC) #2
Jun Mukai
https://codereview.chromium.org/19471016/diff/1/ui/message_center/views/message_view.cc File ui/message_center/views/message_view.cc (right): https://codereview.chromium.org/19471016/diff/1/ui/message_center/views/message_view.cc#newcode434 ui/message_center/views/message_view.cc:434: event->type() != ui::ET_SCROLL_FLING_START) by the way, should it also ...
7 years, 5 months ago (2013-07-24 00:52:08 UTC) #3
sadrul
Committed patchset #2 manually as r213335 (presubmit successful).
7 years, 5 months ago (2013-07-24 04:45:17 UTC) #4
sadrul
7 years, 5 months ago (2013-07-24 04:46:42 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/19471016/diff/1/ui/message_center/views/messa...
File ui/message_center/views/message_view.cc (right):

https://codereview.chromium.org/19471016/diff/1/ui/message_center/views/messa...
ui/message_center/views/message_view.cc:434: event->type() !=
ui::ET_SCROLL_FLING_START)
On 2013/07/24 00:52:08, Jun Mukai wrote:
> by the way, should it also check ET_SCROLL_FLING_CANCEL in case the user wants
> to cancel the fling scroll?

Done.

(The gesture-recognizer never generates a FLING_CANCEL event. So confusingly
enough, we don't actually need to check for this. But it's better to check for
that for readability if nothing else.)

Powered by Google App Engine
This is Rietveld 408576698