Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chrome/browser/ui/gtk/gtk_theme_service.cc

Issue 19471005: Add custom default theme support and create a managed user default theme. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments and add tests. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/gtk_theme_service.cc
diff --git a/chrome/browser/ui/gtk/gtk_theme_service.cc b/chrome/browser/ui/gtk/gtk_theme_service.cc
index 53378609ccdd332607c100d01bc87f7cac4f0fdf..4df7e18977e143354c90cc7e118e4166878b928a 100644
--- a/chrome/browser/ui/gtk/gtk_theme_service.cc
+++ b/chrome/browser/ui/gtk/gtk_theme_service.cc
@@ -309,14 +309,6 @@ gfx::ImageSkia* GtkThemeService::GetImageSkiaNamed(int id) const {
}
gfx::Image GtkThemeService::GetImageNamed(int id) const {
- // TODO(akuegel): Remove this once we have the default managed user theme.
- if (ManagedUserService::ProfileIsManaged(profile())) {
- if (id == IDR_THEME_FRAME)
- id = IDR_MANAGED_USER_THEME_FRAME;
- else if (id == IDR_THEME_FRAME_INACTIVE)
- id = IDR_MANAGED_USER_THEME_FRAME_INACTIVE;
- }
-
// Try to get our cached version:
ImageCache::const_iterator it = gtk_images_.find(id);
if (it != gtk_images_.end())
@@ -333,14 +325,6 @@ gfx::Image GtkThemeService::GetImageNamed(int id) const {
}
SkColor GtkThemeService::GetColor(int id) const {
- // TODO(akuegel): Remove this once we have the default managed user theme.
- if (ManagedUserService::ProfileIsManaged(profile())) {
- if (id == ThemeProperties::COLOR_FRAME)
- id = ThemeProperties::COLOR_FRAME_MANAGED_USER;
- else if (id == ThemeProperties::COLOR_FRAME_INACTIVE)
- id = ThemeProperties::COLOR_FRAME_MANAGED_USER_INACTIVE;
- }
-
if (use_gtk_) {
ColorMap::const_iterator it = colors_.find(id);
if (it != colors_.end())
@@ -369,6 +353,10 @@ void GtkThemeService::SetTheme(const extensions::Extension* extension) {
ThemeService::SetTheme(extension);
}
+bool GtkThemeService::ShouldInitWithNativeTheme() {
+ return profile()->GetPrefs()->GetBoolean(prefs::kUsesSystemTheme);
+}
+
void GtkThemeService::UseDefaultTheme() {
profile()->GetPrefs()->SetBoolean(prefs::kUsesSystemTheme, false);
LoadDefaultValues();
@@ -650,13 +638,9 @@ void GtkThemeService::ClearAllThemeData() {
}
void GtkThemeService::LoadThemePrefs() {
- if (use_gtk_) {
- LoadGtkValues();
- set_ready();
- } else {
- LoadDefaultValues();
- ThemeService::LoadThemePrefs();
- }
+ LoadDefaultValues();
+ // This takes care of calling SetNativeTheme() if necessary.
+ ThemeService::LoadThemePrefs();
SetXDGIconTheme();
RebuildMenuIconSets();

Powered by Google App Engine
This is Rietveld 408576698