LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-start.html - Issue 19471004: Rendering the property, text-align-last.

Side by Side Diff: LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-start.html

Issue 19471004: Rendering the property, text-align-last. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 1st patch for review Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/css3-text/css3-text-align-last/text-align-last.css ('K') | « LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-right-expected.html ('k') | LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-start-expected.html » ('j') | LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-start-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html lang="en">
	Julien - ping for review 2013/10/22 15:06:06 Let's remove the lang attribute. Let's remove the lang attribute. dw.im 2013/10/23 02:40:58 will remove it. Show quoted text On 2013/10/22 15:06:06, Julien Chaffraix wrote: > Let's remove the lang attribute. will remove it.
	3 <head>

	4 <link href="text-align-last.css" rel="stylesheet" type="text/css">

	5 <style type="text/css"> div {text-align-last:start} </style>
	Julien - ping for review 2013/10/22 15:06:06 Again a super broad selector which makes the test Again a super broad selector which makes the test confusing. I had missed it in my first review and thus didn't understand why everything was text-align-last: start (and not auto the initial value). I think this should be a class and you explicitly mark the divs so that the intent is clearer. dw.im 2013/10/23 02:40:58 I want to test text-align-last:start works properl Show quoted text On 2013/10/22 15:06:06, Julien Chaffraix wrote: > Again a super broad selector which makes the test confusing. I had missed it in > my first review and thus didn't understand why everything was text-align-last: > start (and not auto the initial value). > > I think this should be a class and you explicitly mark the divs so that the > intent is clearer. I want to test text-align-last:start works properly with various text-align values, in this test case. The other values of text-align-last are tested in its dedicated test case.
	6 </head>

	7 <body>

	8 <title>Test Case for text-align-last:start</title>

	9 <h1 style="font-size: 1em;">text-align-last: start</h1>

	10
	Julien - ping for review 2013/10/22 15:06:06 What's expected? How can someone unfamiliar with t What's expected? How can someone unfamiliar with the test knows if it passes? dw.im 2013/10/23 02:40:58 There is -expected.html file, but still I can up Show quoted text On 2013/10/22 15:06:06, Julien Chaffraix wrote: > What's expected? How can someone unfamiliar with the test knows if it passes? There is -expected.html file, but still I can upload the result png file as a reference. I didn't make the test as pixel test because I don't want to add more png files in trunk. If you think pixel test could be more clear, I will try to make it in that way. Julien - ping for review 2013/10/23 15:41:51 Yes, we don't want pixel tests but you missed the Show quoted text On 2013/10/23 02:40:58, dw.im wrote: > On 2013/10/22 15:06:06, Julien Chaffraix wrote: > > What's expected? How can someone unfamiliar with the test knows if it passes? > > There is -expected.html file, > but still I can upload the result png file as a reference. > > I didn't make the test as pixel test because I don't want to add more png files > in trunk. > > If you think pixel test could be more clear, I will try to make it in that way. Yes, we don't want pixel tests but you missed the point: what I am asking for is a description* of the test that clearly states what passing means to the casual reader of the test.
	11 <div dir="ltr" style="text-align:start;">1 LTR align is start align-last is start. </div>

	12 <div dir="ltr" style="text-align:end;">2 LTR align is end align-last is star t. </div>

	13 <div dir="ltr" style="text-align:left;">3 LTR align is left align-last is st art. </div>

	14 <div dir="ltr" style="text-align:right;">4 LTR align is right align-last is start. </div>

	15

	16 <div dir="rtl" style="text-align:start;">5 RTL align is start align-last is start. </div>

	17 <div dir="rtl" style="text-align:end;">6 RTL align is end align-last is star t. </div>

	18 </body>

	19 </html>

OLD	NEW