Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1418)

Issue 1947093002: Revert of Remove unneeded CPVT classes. (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Remove unneeded CPVT classes. (patchset #7 id:140001 of https://codereview.chromium.org/1919283008/ ) Reason for revert: Causing segv on certain PDFs which make the PDF load tests hang. crbug.com/608901 Original issue's description: > Remove unneeded CPVT classes. > > - CPVT_Size is the same as CFX_PointF > - CPVT_FloatRange is unused. > - CPVT_ArrayTemplate is just a wrapper for CFX_ArrayTemplate. > > Committed: https://pdfium.googlesource.com/pdfium/+/a354eb517429e10d84abff65e455f0c183fe58e0 TBR=thestig@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://pdfium.googlesource.com/pdfium/+/696fc8b70c19cf35fd10bc10f547aae74fc6333c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -363 lines) Patch
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_variabletext.cpp View 6 chunks +41 lines, -45 lines 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/csection.h View 3 chunks +3 lines, -4 lines 0 comments Download
M core/fpdfdoc/ctypeset.h View 1 chunk +2 lines, -5 lines 0 comments Download
D core/fpdfdoc/doc_vt.h View 1 chunk +0 lines, -103 lines 0 comments Download
M core/fpdfdoc/doc_vt.cpp View 8 chunks +161 lines, -199 lines 0 comments Download
M core/fpdfdoc/include/cpdf_variabletext.h View 3 chunks +4 lines, -4 lines 0 comments Download
A core/fpdfdoc/pdf_vt.h View 1 chunk +149 lines, -0 lines 0 comments Download
M pdfium.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
dsinclair
Created Revert of Remove unneeded CPVT classes.
4 years, 4 months ago (2016-05-04 14:39:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947093002/1
4 years, 4 months ago (2016-05-04 14:40:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/696fc8b70c19cf35fd10bc10f547aae74fc6333c
4 years, 4 months ago (2016-05-04 14:53:00 UTC) #4
Lei Zhang
4 years, 4 months ago (2016-05-09 18:58:10 UTC) #5
Message was sent while issue was closed.
lgtm, will take a look.

Powered by Google App Engine
This is Rietveld 408576698