Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp

Issue 1947053002: Manual revert of "Preload scan external css for @import" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Keep histograms.xml Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp b/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp
index 19e8b68357cf27bd712ecd7bb63d734d2f68796a..15a5aaf1d36714052c7ccaf8db2548737a75454c 100644
--- a/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp
+++ b/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp
@@ -27,11 +27,8 @@
#include "core/html/parser/CSSPreloadScanner.h"
-#include "core/fetch/CSSStyleSheetResource.h"
#include "core/fetch/FetchInitiatorTypeNames.h"
#include "core/html/parser/HTMLParserIdioms.h"
-#include "core/html/parser/HTMLResourcePreloader.h"
-#include "platform/Histogram.h"
#include "platform/text/SegmentedString.h"
namespace blink {
@@ -236,39 +233,4 @@ void CSSPreloadScanner::emitRule(const SegmentedString& source)
m_ruleValue.clear();
}
-CSSPreloaderResourceClient::CSSPreloaderResourceClient(Resource* resource, HTMLResourcePreloader* preloader)
- : m_resource(resource)
- , m_preloader(preloader)
-{
-}
-
-void CSSPreloaderResourceClient::notifyFinished(Resource* resource)
-{
- resource->removeClient(this);
- m_resource.clear();
-}
-
-// Only attach for one appendData call, as that's where most imports will likely
-// be (according to spec).
-void CSSPreloaderResourceClient::didAppendFirstData(const CSSStyleSheetResource* resource)
-{
- const String& chunk = resource->decodedText();
- if (!chunk.isNull() && m_preloader) {
- CSSPreloadScanner cssPreloadScanner;
- PreloadRequestStream preloads;
- // Passing an empty SegmentedString here results in PreloadRequests
- // with no file/line information.
- // TODO(csharrison): If this becomes an issue the CSSPreloadScanner
- // may be augmented to take care of this case without performing an
- // additional copy.
- cssPreloadScanner.scan(chunk, SegmentedString(), preloads, resource->response().url());
- int currentPreloadCount = m_preloader->countPreloads();
- m_preloader->takeAndPreload(preloads);
- DEFINE_STATIC_LOCAL(CustomCountHistogram, cssImportHistogram, ("PreloadScanner.ExternalCSS.PreloadCount", 1, 100, 50));
- cssImportHistogram.count(m_preloader->countPreloads() - currentPreloadCount);
- }
- m_resource->removeClient(this);
- m_resource.clear();
-}
-
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698