Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1947053002: Manual revert of "Preload scan external css for @import" (Closed)

Created:
4 years, 7 months ago by Charlie Harrison
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-style_chromium.org, tfarina, blink-reviews-html_chromium.org, Yoav Weiss, dglazkov+blink, gavinp+loader_chromium.org, asvitkine+watch_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manual revert of "Preload scan external css for @import" This reverts commit c3698d693def17f7f4c2d17f462de63ee06fe10d. https://codereview.chromium.org/1819593002 It was causing some crashes / layout test flakiness TBR=kinuko@chromium.org,kouhei@chromium.org BUG=608577, 608310 Committed: https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242 Cr-Commit-Position: refs/heads/master@{#391506}

Patch Set 1 #

Patch Set 2 : Keep histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -119 lines) Patch
D third_party/WebKit/LayoutTests/http/tests/preload/external_css_import_preload.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/resources/css_with_import.css View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/StyleSheetResourceClient.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h View 2 chunks +1 line, -18 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp View 2 chunks +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.h View 3 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp View 3 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947053002/20001
4 years, 7 months ago (2016-05-04 13:23:52 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 14:47:32 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 14:48:52 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3ac78e618532b15d8d26af86808f1028f4d62242
Cr-Commit-Position: refs/heads/master@{#391506}

Powered by Google App Engine
This is Rietveld 408576698