Site Settings on Desktop: Align some of the UI elements better.

Site Settings on Desktop: Align some of the UI elements better.

BUG=608131
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e3f2a8ff6eb87f48c53a7f9379bdf0d417b0cbcf
Cr-Commit-Position: refs/heads/master@{#392276}

[Finnur, 2016-05-06 14:52:31]

finnur@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2016-05-06 19:55:08]

as a warning, this will change soon to avoid paper*item* usage once we resolve
paper-item bugs. The styles should "just work" but we'll probably have to verify
that everything is still styled the same.

https://codereview.chromium.org/1947033003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_settings_category.html
(right):

https://codereview.chromium.org/1947033003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_settings_category.html:21:
<iron-icon icon="[[computeIconForContentCategory(category)]]"
class="toggle-icon"
wrap

[michaelpg, 2016-05-06 19:55:23]

On 2016/05/06 19:55:08, michaelpg wrote:
> as a warning, this will change soon to avoid paper*item* usage once we resolve
> paper-item bugs. The styles should "just work" but we'll probably have to
verify
> that everything is still styled the same.
> 
>
https://codereview.chromium.org/1947033003/diff/1/chrome/browser/resources/se...
> File
chrome/browser/resources/settings/site_settings/site_settings_category.html
> (right):
> 
>
https://codereview.chromium.org/1947033003/diff/1/chrome/browser/resources/se...
>
chrome/browser/resources/settings/site_settings/site_settings_category.html:21:
> <iron-icon icon="[[computeIconForContentCategory(category)]]"
> class="toggle-icon"
> wrap

and i meant to lgtm

[Finnur, 2016-05-08 10:14:11]

All done. Checking in. Thanks for the heads-up.

https://codereview.chromium.org/1947033003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_settings_category.html
(right):

https://codereview.chromium.org/1947033003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_settings_category.html:21:
<iron-icon icon="[[computeIconForContentCategory(category)]]"
class="toggle-icon"
On 2016/05/06 19:55:08, michaelpg wrote:
> wrap

Done.

[Finnur, 2016-05-08 10:14:19]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-05-08 10:14:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1947033003/#ps20001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-05-08 10:14:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947033003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947033003/20001

[commit-bot: I haz the power, 2016-05-08 10:16:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-08 10:16:20]

Try jobs failed on following builders:
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Finnur, 2016-05-08 10:49:44]

Description was changed from

==========
Site Settings on Desktop: Align some of the UI elements better.

BUG=608131
==========

to

==========
Site Settings on Desktop: Align some of the UI elements better.

BUG=608131
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-05-08 10:50:51]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-05-08 10:50:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1947033003/#ps40001
(title: "Sync to head")

[commit-bot: I haz the power, 2016-05-08 10:50:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1947033003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1947033003/40001

[commit-bot: I haz the power, 2016-05-08 11:45:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-08 11:46:29]

Description was changed from

==========
Site Settings on Desktop: Align some of the UI elements better.

BUG=608131
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings on Desktop: Align some of the UI elements better.

BUG=608131
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e3f2a8ff6eb87f48c53a7f9379bdf0d417b0cbcf
Cr-Commit-Position: refs/heads/master@{#392276}
==========

[commit-bot: I haz the power, 2016-05-08 11:46:30]

Patchset 3 (id:??) landed as
https://crrev.com/e3f2a8ff6eb87f48c53a7f9379bdf0d417b0cbcf
Cr-Commit-Position: refs/heads/master@{#392276}