third_party/WebKit/Source/core/html/track/TextTrack.h - Issue 1947033002: Change "invalid value default" for HTMLTrackElement 'kind' to "metadata"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/TextTrack.h

Issue 1947033002: Change "invalid value default" for HTMLTrackElement 'kind' to "metadata" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp ('k') | third_party/WebKit/Source/core/html/track/TrackBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/TextTrack.h

diff --git a/third_party/WebKit/Source/core/html/track/TextTrack.h b/third_party/WebKit/Source/core/html/track/TextTrack.h

index f645a127dcdf26713a9e25e7d02897cf2bb04203..8a69cdcc72d66c9a1d811ef260da37a1cf9e5b4b 100644

--- a/third_party/WebKit/Source/core/html/track/TextTrack.h

+++ b/third_party/WebKit/Source/core/html/track/TextTrack.h

@@ -123,7 +123,7 @@ protected:

TextTrack(const AtomicString& kind, const AtomicString& label, const AtomicString& language, const AtomicString& id, TextTrackType);

bool isValidKind(const AtomicString& kind) const override { return isValidKindKeyword(kind); }

- AtomicString defaultKind() const override { return subtitlesKeyword(); }

+ AtomicString invalidValueDefaultKind() const override { return metadataKeyword(); }

void addListOfCues(HeapVector<Member<TextTrackCue>>&);