third_party/WebKit/LayoutTests/media/track/track-kind.html - Issue 1947033002: Change "invalid value default" for HTMLTrackElement 'kind' to "metadata"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-kind.html

Issue 1947033002: Change "invalid value default" for HTMLTrackElement 'kind' to "metadata" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/opera/interfaces/TextTrack/kind.html ('k') | third_party/WebKit/LayoutTests/media/track/track-kind-expected.txt » ('j') | third_party/WebKit/Source/core/html/track/TextTrack.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-kind.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-kind.html b/third_party/WebKit/LayoutTests/media/track/track-kind.html

index 8a223601af5585273b4caf18158c2f5f35f8ed4f..f98ac338d90780e77bae4ccdbefff12bda98e13a 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-kind.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-kind.html

@@ -25,7 +25,6 @@

testExpected("trackElement.kind", value);

testExpected("trackElement.track.kind", value);

testExpected("trackElement.getAttribute('kind')", value);

- testExpected("textTrackDisplayElement(video, 'display').innerText", "Lorem ipsum dolor sit amet, ");

consoleWrite("");

}

@@ -44,13 +43,13 @@

run("trackElement.removeAttribute('kind')");

run("trackElement.kind = '" + value + "'");

testExpected("trackElement.getAttribute('kind')", value);

- testExpected("trackElement.kind", "subtitles");

- testExpected("trackElement.track.kind", "subtitles");

+ testExpected("trackElement.kind", "metadata");

+ testExpected("trackElement.track.kind", "metadata");

consoleWrite("<b> and via attribute</b>");

run("trackElement.removeAttribute('kind')");

run("trackElement.setAttribute('kind', '" + value + "')");

- testExpected("trackElement.kind", "subtitles");

- testExpected("trackElement.track.kind", "subtitles");

+ testExpected("trackElement.kind", "metadata");

+ testExpected("trackElement.track.kind", "metadata");

testExpected("trackElement.getAttribute('kind')", value);

consoleWrite("");