[Mac][Material Design] Fix TabStripController test that fails under MD.

[Mac][Material Design] Fix TabStripController test that fails under MD.

This cl fixes a bug in one of the TabStripController unit tests. The
test used hard-coded mouse coordinates which no longer work because of
the new max tab width in Material Design.

This cl also fixes a bug where the new Material Design max tab width
was being used on non-MD.

R=avi@chromium.org
BUG=609254
Committed: https://crrev.com/a8910b7b3b79c8ea6c508bc06c14fd4e1e84c0fd
Cr-Commit-Position: refs/heads/master@{#391684}

[shrike, 2016-05-04 20:43:26]

PTAL

[Avi (use Gerrit), 2016-05-04 20:57:21]

lgtm

https://codereview.chromium.org/1946993004/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

https://codereview.chromium.org/1946993004/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:922: const CGFloat
tabOverlap = [TabStripController tabOverlap];
kTabOverlap is taken, but having this be not a k... where all the other
constants are k... is weird.

[shrike, 2016-05-04 21:15:20]

PTAL

https://codereview.chromium.org/1946993004/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

https://codereview.chromium.org/1946993004/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:922: const CGFloat
tabOverlap = [TabStripController tabOverlap];
On 2016/05/04 20:57:20, Avi wrote:
> kTabOverlap is taken, but having this be not a k... where all the other
> constants are k... is weird.

Yeah, it needs to (sorry, still locking all of our coding conventions into my
head). I moved the others out of the global scope which allows me create it
again as needed. Once we remove the old UI code the tabOverlap method can
probably just return a number instead of declare it first.

[Avi (use Gerrit), 2016-05-04 21:55:46]

lgtm

[shrike, 2016-05-04 22:07:52]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-05-04 22:08:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946993004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946993004/20001

[commit-bot: I haz the power, 2016-05-04 23:22:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-04 23:23:42]

Description was changed from

==========
[Mac][Material Design] Fix TabStripController test that fails under MD.

This cl fixes a bug in one of the TabStripController unit tests. The
test used hard-coded mouse coordinates which no longer work because of
the new max tab width in Material Design.

This cl also fixes a bug where the new Material Design max tab width
was being used on non-MD.

R=avi@chromium.org
BUG=609254
==========

to

==========
[Mac][Material Design] Fix TabStripController test that fails under MD.

This cl fixes a bug in one of the TabStripController unit tests. The
test used hard-coded mouse coordinates which no longer work because of
the new max tab width in Material Design.

This cl also fixes a bug where the new Material Design max tab width
was being used on non-MD.

R=avi@chromium.org
BUG=609254

Committed: https://crrev.com/a8910b7b3b79c8ea6c508bc06c14fd4e1e84c0fd
Cr-Commit-Position: refs/heads/master@{#391684}
==========

[commit-bot: I haz the power, 2016-05-04 23:23:42]

Patchset 2 (id:??) landed as
https://crrev.com/a8910b7b3b79c8ea6c508bc06c14fd4e1e84c0fd
Cr-Commit-Position: refs/heads/master@{#391684}