Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1946933002: Generalize ReferenceableElementForLink to work with explicit getters. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generalize ReferenceableElementForLink to work with explicit getters. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c6086791e8980b9517c16845a684530814e5984a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -54 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 6 chunks +30 lines, -38 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 3 chunks +30 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-04 02:35:44 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-04 02:39:29 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-04 04:05:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c6086791e8980b9517c16845a684530814e5984a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698