Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1946883003: Ship Turbofan optimization for try-catch and try-finally. (Closed)

Created:
4 years, 7 months ago by Jarin
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, mvstanton, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship Turbofan optimization for try-catch and try-finally. Committed: https://crrev.com/b84b01e6d2d8a0ed1e6b9186a5af755bab4bac9a Cr-Commit-Position: refs/heads/master@{#36005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ast/ast-numbering.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jarin
Another attempt... Could you take a look, please?
4 years, 7 months ago (2016-05-04 05:52:50 UTC) #2
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-04 05:53:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946883003/1
4 years, 7 months ago (2016-05-04 05:53:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 06:42:56 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b84b01e6d2d8a0ed1e6b9186a5af755bab4bac9a Cr-Commit-Position: refs/heads/master@{#36005}
4 years, 7 months ago (2016-05-04 06:43:47 UTC) #8
Michael Hablich
4 years, 7 months ago (2016-05-18 07:14:15 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1994543002/ by hablich@chromium.org.

The reason for reverting is: Reverted because of
BUG=chromium:611885.

Powered by Google App Engine
This is Rietveld 408576698