Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1946883002: Enabling /ZW (CompileAsWinRT) option for msvs (Closed)

Created:
4 years, 7 months ago by munyirik1
Modified:
4 years, 7 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Enabling /ZW (CompileAsWinRT) option for msvs This change enables someone using gyp to specify the CompileAsWinRT option (i.e. use the /ZW compiler flag). The change also includes: - Test for CompileAsWinRT (change in test/win/compiler-flags) - Enabling Visual Studio 2015 to be targeted by tests (change in testgyp.py) - Detecting Windows SDK version if 'msvs_windows_sdk_version' is used (change in msvs.py) - Enabling arm target architecture to be specified (change in msvs.py) Patch from munyirik@microsoft.com. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/02b145a1a4f4e1c62e8bae06045caf852d9ef17f

Patch Set 1 #

Patch Set 2 : Fix line endings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
M pylib/gyp/MSVSSettings.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M pylib/gyp/generator/msvs.py View 1 3 chunks +32 lines, -0 lines 0 comments Download
M test/lib/TestGyp.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/win/compiler-flags/compile-as-winrt.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A test/win/compiler-flags/compile-as-winrt.gyp View 1 chunk +20 lines, -0 lines 0 comments Download
A test/win/gyptest-cl-compile-as-winrt.py View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
munyirik1
Hi Scott, This is the same as https://codereview.chromium.org/1845943002 but I've now submitted with the correct ...
4 years, 7 months ago (2016-05-04 00:48:55 UTC) #2
scottmg
The diffstat says (+5839 lines, -5753 lines), likely you've changed the line endings? With that ...
4 years, 7 months ago (2016-05-04 16:55:59 UTC) #3
munyirik
On 2016/05/04 16:55:59, scottmg wrote: > The diffstat says (+5839 lines, -5753 lines), likely you've ...
4 years, 7 months ago (2016-05-04 17:40:41 UTC) #4
scottmg
Committed patchset #2 (id:20001) manually as 02b145a1a4f4e1c62e8bae06045caf852d9ef17f (presubmit successful).
4 years, 7 months ago (2016-05-04 18:19:09 UTC) #7
scottmg
4 years, 7 months ago (2016-05-04 18:19:26 UTC) #8
Message was sent while issue was closed.
On 2016/05/04 18:19:09, scottmg wrote:
> Committed patchset #2 (id:20001) manually as
> 02b145a1a4f4e1c62e8bae06045caf852d9ef17f (presubmit successful).

Thanks for the patch!

Powered by Google App Engine
This is Rietveld 408576698