Fix event sending in pdfium_test.

Fix event sending in pdfium_test.

Passing bad args in pdfium_test -- all void* pointers look alike.
Make output less verbose while we're here. Turn on event sending
mode for corups tests. No effect until .evt files added to corpus.

Committed: https://pdfium.googlesource.com/pdfium/+/10b01bf44695ce9a354660b16f607da70727a846

[Tom Sepez, 2016-05-04 17:57:29]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-05-04 17:57:29]

Dan, please review.

[dsinclair, 2016-05-04 18:01:19]

https://codereview.chromium.org/1946873004/diff/1/testing/tools/run_corpus_te...
File testing/tools/run_corpus_tests.py (right):

https://codereview.chromium.org/1946873004/diff/1/testing/tools/run_corpus_te...
testing/tools/run_corpus_tests.py:45: cmd_to_run.extend([pdfium_test_path,
'--send-events', '--png', pdf_path])
Would there be any harm in passing this in the test_runner.py script as well?
Would keep them consistent.

[Tom Sepez, 2016-05-04 19:23:22]

On 2016/05/04 18:01:19, dsinclair wrote:
>
https://codereview.chromium.org/1946873004/diff/1/testing/tools/run_corpus_te...
> File testing/tools/run_corpus_tests.py (right):
> 
>
https://codereview.chromium.org/1946873004/diff/1/testing/tools/run_corpus_te...
> testing/tools/run_corpus_tests.py:45: cmd_to_run.extend([pdfium_test_path,
> '--send-events', '--png', pdf_path])
> Would there be any harm in passing this in the test_runner.py script as well?
> Would keep them consistent.

Just a bunch of failed fopens() that we know can never succeed, probably not
significant cost.

[Tom Sepez, 2016-05-04 19:24:46]

https://codereview.chromium.org/1946873004/diff/1/testing/tools/run_corpus_te...
File testing/tools/run_corpus_tests.py (right):

https://codereview.chromium.org/1946873004/diff/1/testing/tools/run_corpus_te...
testing/tools/run_corpus_tests.py:45: cmd_to_run.extend([pdfium_test_path,
'--send-events', '--png', pdf_path])
On 2016/05/04 18:01:19, dsinclair wrote:
> Would there be any harm in passing this in the test_runner.py script as well?
> Would keep them consistent.

Done.

[dsinclair, 2016-05-04 19:25:24]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-05-04 19:25:25]

lgtm

[commit-bot: I haz the power, 2016-05-04 19:25:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946873004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946873004/20001

[commit-bot: I haz the power, 2016-05-04 19:52:46]

Description was changed from

==========
Fix event sending in pdfium_test.

Passing bad args in pdfium_test -- all void* pointers look alike.
Make output less verbose while we're here. Turn on event sending
mode for corups tests. No effect until .evt files added to corpus.
==========

to

==========
Fix event sending in pdfium_test.

Passing bad args in pdfium_test -- all void* pointers look alike.
Make output less verbose while we're here. Turn on event sending
mode for corups tests. No effect until .evt files added to corpus.

Committed:
https://pdfium.googlesource.com/pdfium/+/10b01bf44695ce9a354660b16f607da70727...
==========

[commit-bot: I haz the power, 2016-05-04 19:52:46]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/10b01bf44695ce9a354660b16f607da70727...