Fix -Wbool-conversion warnings in hunspell.

Fix -Wbool-conversion warnings in hunspell:

../../third_party/hunspell/src/hunspell/hunspell.cxx:355:7: error: address of array 'this->pHMgr' will always evaluate to 'true' [-Werror,-Wbool-conversion]
  if (pHMgr) pHMgr[0]->EmptyHentryCache();
  ~~  ^~~~~
../../third_party/hunspell/src/hunspell/hunspell.cxx:718:7: error: address of array 'this->pHMgr' will always evaluate to 'true' [-Werror,-Wbool-conversion]
  if (pHMgr) pHMgr[0]->EmptyHentryCache();
  ~~  ^~~~~


BUG=350358
R=thakis@chromium.org

[Alexander Potapenko, 2014-03-11 10:50:43]

PTAL

[Nico, 2014-03-11 16:40:55]

https://codereview.chromium.org/194683004/diff/1/README.chromium
File README.chromium (right):

https://codereview.chromium.org/194683004/diff/1/README.chromium#newcode24
README.chromium:24: * Fix -Wbool-conversion warnings from Clang in
src/hunspell/hunspell.cxx.
Since the change is in code that's only in the existing diff, not in hunspell
itself, I think you don't need to change the README file.

https://codereview.chromium.org/194683004/diff/1/src/hunspell/hunspell.cxx
File src/hunspell/hunspell.cxx (left):

https://codereview.chromium.org/194683004/diff/1/src/hunspell/hunspell.cxx#ol...
src/hunspell/hunspell.cxx:355: if (pHMgr) pHMgr[0]->EmptyHentryCache();
Can you paste the warning? (Often a good idea to include the warning text in the
Cl description for warning fixes.) This looks like a valid check to me at first
sight.

[Alexander Potapenko, 2014-03-11 17:38:47]

https://codereview.chromium.org/194683004/diff/1/README.chromium
File README.chromium (right):

https://codereview.chromium.org/194683004/diff/1/README.chromium#newcode24
README.chromium:24: * Fix -Wbool-conversion warnings from Clang in
src/hunspell/hunspell.cxx.
On 2014/03/11 16:40:55, Nico wrote:
> Since the change is in code that's only in the existing diff, not in hunspell
> itself, I think you don't need to change the README file.

Done.

https://codereview.chromium.org/194683004/diff/1/src/hunspell/hunspell.cxx
File src/hunspell/hunspell.cxx (left):

https://codereview.chromium.org/194683004/diff/1/src/hunspell/hunspell.cxx#ol...
src/hunspell/hunspell.cxx:355: if (pHMgr) pHMgr[0]->EmptyHentryCache();
On 2014/03/11 16:40:55, Nico wrote:
> Can you paste the warning? (Often a good idea to include the warning text in
the
> Cl description for warning fixes.) This looks like a valid check to me at
first
> sight.
Updated the CL description.
Maybe it used to be a pointer, but was converted to an array later.
Other accesses to pHMgr[0] in this file do not check for pHMgr.

[Nico, 2014-03-11 17:42:13]

lgtm with the change below

https://codereview.chromium.org/194683004/diff/20001/src/hunspell/hunspell.cxx
File src/hunspell/hunspell.cxx (left):

https://codereview.chromium.org/194683004/diff/20001/src/hunspell/hunspell.cx...
src/hunspell/hunspell.cxx:355: if (pHMgr) pHMgr[0]->EmptyHentryCache();
Several places check `if (pHMgr[0])` though (e.g. Hunspell::add). It's not
necessary since pHMgr[0] is unconditionally initialized with new and that can't
return 0, but for consistency in this file you should probably change the if to
if (pHMgr[0])  instead of removing it.

[Alexander Potapenko, 2014-03-11 17:49:15]

Done.

[Alexander Potapenko, 2014-03-11 17:49:28]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-03-11 17:49:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glider@chromium.org/194683004/40001

[commit-bot: I haz the power, 2014-03-11 17:50:00]

Change committed as 256272